Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack dtor for mysqli to cleanup resources. #45

Merged
merged 1 commit into from Jan 18, 2023
Merged

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Jan 17, 2023

Hack the destructor to remove the global hash map value hold by the object id key, to cleanup resources.

This is done for other plugins, only mysqli is left.

@jmjoy jmjoy added this to the 0.3.0 milestone Jan 17, 2023
@jmjoy jmjoy marked this pull request as ready for review January 17, 2023 10:57
@wu-sheng
Copy link
Member

Could you explain what is this hack about?

@jmjoy
Copy link
Member Author

jmjoy commented Jan 18, 2023

Could you explain what is this hack about?

Hack the destructor to remove the global hash map value hold by the object id key, to cleanup resources.

This is done for other plugins, only mysqli is left.

@jmjoy jmjoy changed the title Hack dtor for mysqli. Hack dtor for mysqli to cleanup resources. Jan 18, 2023
@wu-sheng wu-sheng merged commit 9d76bc3 into apache:master Jan 18, 2023
@jmjoy jmjoy deleted the mysqli branch January 18, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants