Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TLS. #49

Merged
merged 3 commits into from Jan 28, 2023
Merged

Support TLS. #49

merged 3 commits into from Jan 28, 2023

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Jan 28, 2023

  1. Add config option skywalking_agent.enable_tls, skywalking_agent.ssl_trusted_ca_path, skywalking_agent.ssl_key_path, skywalking_agent.ssl_cert_chain_path.
  2. Remove http:// scheme in skywalking_agent.server_addr.

@jmjoy jmjoy added this to the 0.3.0 milestone Jan 28, 2023
@wu-sheng
Copy link
Member

Remember to mark this as a breaking change in the release note.(http prefix removed.)

@jmjoy
Copy link
Member Author

jmjoy commented Jan 28, 2023

Remember to mark this as a breaking change in the release note.(http prefix removed.)

OK

@jmjoy jmjoy marked this pull request as ready for review January 28, 2023 06:02
@jmjoy jmjoy requested a review from wu-sheng January 28, 2023 06:02
@wu-sheng wu-sheng merged commit 9d161d5 into apache:master Jan 28, 2023
@jmjoy jmjoy deleted the tls branch January 28, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
2 participants
@jmjoy @wu-sheng