Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid potential panic for logger. #54

Merged
merged 2 commits into from Feb 11, 2023
Merged

Avoid potential panic for logger. #54

merged 2 commits into from Feb 11, 2023

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Feb 10, 2023

Because tracing-appender may panic when it is created, such as permission denied, so remove it and create the log file by myself.

@jmjoy jmjoy added the bug Something isn't working label Feb 10, 2023
@jmjoy jmjoy added this to the 0.4.0 milestone Feb 10, 2023
@jmjoy jmjoy marked this pull request as ready for review February 11, 2023 03:03
@wu-sheng wu-sheng merged commit 9fb087b into apache:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@heyanlong heyanlong Awaiting requested review from heyanlong

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.4.0
2 participants
@jmjoy @wu-sheng