Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish doc about Swoole #73

Merged
merged 2 commits into from May 10, 2023
Merged

Polish doc about Swoole #73

merged 2 commits into from May 10, 2023

Conversation

wu-sheng
Copy link
Member

Is this a better way?

@wu-sheng wu-sheng added the documentation Improvements or additions to documentation label May 10, 2023
@wu-sheng wu-sheng added this to the 0.6.0 milestone May 10, 2023
@wu-sheng wu-sheng requested a review from jmjoy May 10, 2023 03:12
@jmjoy
Copy link
Member

jmjoy commented May 10, 2023

SWOOLE_HOOK_ALL isn't the deprecated feature.

The meaning of this sentence is that whether using PHP native synchronization IO or using swoole hooked IO, the skywalking agent all supports.

README.md Outdated Show resolved Hide resolved
@wu-sheng
Copy link
Member Author

SWOOLE_HOOK_ALL isn't the deprecated feature.

The meaning of this sentence is that whether using PHP native synchronization IO or using swoole hooked IO, the skywalking agent all supports.

Updated.

@wu-sheng wu-sheng merged commit dfc5aea into master May 10, 2023
18 checks passed
@wu-sheng wu-sheng deleted the wu-sheng-patch-1 branch May 10, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
2 participants