Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notice document for skywalking_agent.enable. #85

Merged
merged 1 commit into from Jul 14, 2023
Merged

Add notice document for skywalking_agent.enable. #85

merged 1 commit into from Jul 14, 2023

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Jul 13, 2023

No description provided.

@jmjoy jmjoy added this to the 0.6.0 milestone Jul 13, 2023
@jmjoy jmjoy requested review from heyanlong and wu-sheng July 14, 2023 01:23
@wu-sheng
Copy link
Member

Could this config be set globally at OS, OS user, or sys env level?
How could it be set but not needed?

@jmjoy
Copy link
Member Author

jmjoy commented Jul 14, 2023

Could this config be set globally at OS, OS user, or sys env level? How could it be set but not needed?

Like in apache/skywalking#11075 , it's not need to enable skywalking-agent for unit tests.

Prefer to set the config like php-fpm -F -d "skywalking_agent.enable=On".

@wu-sheng wu-sheng merged commit a1d6227 into apache:master Jul 14, 2023
24 checks passed
@jmjoy jmjoy deleted the doc branch July 14, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@heyanlong heyanlong Awaiting requested review from heyanlong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
2 participants
@jmjoy @wu-sheng