Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kafka reporter. #88

Merged
merged 16 commits into from Aug 19, 2023
Merged

Add kafka reporter. #88

merged 16 commits into from Aug 19, 2023

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Aug 17, 2023

  1. Refactor worker, move reporter logic to standalone module reporter.
  2. Add reporter_kafka to reporter module.
  3. Add configuration options skywalking_agent.reporter_type, skywalking_agent.kafka_bootstrap_servers, skywalking_agent.kafka_producer_config.
  4. Add optional cargo feature kafka-reporter.
  5. Add pecl option.
  6. Update CI.

@jmjoy jmjoy added this to the 0.6.0 milestone Aug 17, 2023
@jmjoy jmjoy marked this pull request as ready for review August 18, 2023 05:13
@wu-sheng
Copy link
Member

Do we need to update readme doc to add this new config?

@wu-sheng wu-sheng added the enhancement New feature or request label Aug 18, 2023
@jmjoy
Copy link
Member Author

jmjoy commented Aug 18, 2023

Do we need to update readme doc to add this new config?

Yes, I just forget.

@jmjoy
Copy link
Member Author

jmjoy commented Aug 19, 2023

@wu-sheng Doc has added.

@wu-sheng wu-sheng merged commit 51622be into apache:master Aug 19, 2023
28 checks passed
@jmjoy jmjoy deleted the kafka-reporter branch August 21, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@heyanlong heyanlong Awaiting requested review from heyanlong

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.6.0
2 participants
@jmjoy @wu-sheng