New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query and dispatch ProfileTaskCommand #127

Merged

Humbertzhang merged 11 commits into apache:master from Humbertzhang:master

Jul 12, 2021

Member

Humbertzhang commented Jul 11, 2021 •

edited

This is PR is for Google Summer Of Code 2021 Project: Proposal for Apache SkyWalking: Python agent supports profiling

Add query and dispatch part of ProfileTaskCommand, mainly includes those steps:

1. query ProfileTaskCommand from OAPServer.
2. deserialize command to object
3. dispatch it to appropriate CommandExecutor, here is ProfileTaskCommandExecutor
4. check the ProfileTask's attributes is rational and add it in profile task queue

It uses two threads to complete the task: QueryProfileCommandThread for query and CommandDispatchThread for command dispatch and check.

This PR is the first part of apache/skywalking#5943. I will add the execute part and tests for profiling feature in following PRs.

Humbertzhang added 9 commits

July 11, 2021 11:09


          add profile command receive from oapserver and commandservice

7e20120


          format profile log

339e959


          merge from master

b2074df


          add configs for profile

41bb5ed


          polish codes

bd88da5


          update EnvVars doc

5a748f5


          replace deque with Queue

a4ae2b0


          polish CommandSerialNumberCache's deque code

c33a495


          modify protocol

60f2970

Humbertzhang added the core label

Humbertzhang added this to the 0.7.0 milestone

Humbertzhang requested a review from kezhenxu94

July 11, 2021 11:45

kezhenxu94 added the feature label

kezhenxu94 reviewed

View reviewed changes

docs/EnvVars.md Show resolved Hide resolved

kezhenxu94 reviewed

View reviewed changes

docs/EnvVars.md Outdated Show resolved Hide resolved

kezhenxu94 reviewed

View reviewed changes

skywalking/profile/profile_task_execution_service.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/command/base_command.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/command/base_command.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/command/profile_task_command.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/command/profile_task_command.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/command/profile_task_command.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/command/profile_task_command.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/command/profile_task_command.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/command/profile_task_command.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/command/profile_task_command.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/command/profile_task_command.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/command/profile_task_command.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/profile/profile_task.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/profile/profile_task.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/profile/profile_task.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/profile/profile_task.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/profile/profile_task.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/profile/profile_task.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/profile/profile_task.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/profile/profile_task.py Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

skywalking/command/executors/profile_task_command_executor.py Show resolved Hide resolved

Member

wu-sheng commented Jul 11, 2021

Is there going to another PR to execute the profiling task, get snapshots and report to OAP?


          modify according to code reviews and ci

08805d9

Member Author

Humbertzhang commented Jul 11, 2021

Is there going to another PR to execute the profiling task, get snapshots and report to OAP?

Yes, I will add those in next PR


          Merge branch 'master' into master

60b66a0

kezhenxu94 approved these changes

View reviewed changes

Member

kezhenxu94 left a comment

LGTM

Humbertzhang merged commit 2424e81 into apache:master

tom-pytel mentioned this pull request

removed requests as required dependency #128

Merged

Humbertzhang mentioned this pull request

Add Profile function #155

Merged

kezhenxu94 mentioned this pull request

[Python] implements the profiling feature in Python agent apache/skywalking#5943

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment