-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in docker/Makefile #216
Conversation
docker/Makefile
Outdated
@@ -20,11 +20,13 @@ P := grpc http kafka | |||
|
|||
TARGETS := py3.6 py3.7 py3.8 py3.9 py3.10 | |||
|
|||
AGENT_VERSION := 0.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't lock the agent version in CI, this could be left after release.
docker/Makefile
Outdated
@@ -20,11 +20,13 @@ P := grpc http kafka | |||
|
|||
TARGETS := py3.6 py3.7 py3.8 py3.9 py3.10 | |||
|
|||
AGENT_VERSION := 0.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. This is set before running the make targets. Did you read this about how to build docker images? https://github.com/apache/skywalking-python/blob/master/docs/en/contribution/How-to-release-docker.md#how-to-build
py3.6: BASE_PYTHON_IMAGE = python:3.6 | ||
py3.7: BASE_PYTHON_IMAGE = python:3.7 | ||
py3.8: BASE_PYTHON_IMAGE = python:3.8 | ||
py3.9: BASE_PYTHON_IMAGE = python:3.9 | ||
py3.9: BASE_PYTHON_IMAGE = python:3.10 | ||
py3.10: BASE_PYTHON_IMAGE = python:3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good catch!
No description provided.