-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Poetry and bump up e2e #249
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d30a01d
Introduce Poetry and bump up e2e
Superskyyy 5401b93
Change back to upstream infra-e2e
Superskyyy dbe434d
provide a fallback installation for poetry (macos)
Superskyyy cd67b53
Update tests/plugin/Dockerfile.plugin
Superskyyy 176ca09
Address comments to update PR template and fix readme
Superskyyy ace86e3
chore
Superskyyy File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,4 +16,4 @@ | |
# specific language governing permissions and limitations | ||
# under the License. | ||
# | ||
venv | ||
.venv |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,13 @@ | ||
<!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin --> | ||
<!-- Fill the following checklists when a feature/plugin is added or modified--> | ||
<!-- | ||
- [ ] Add a test case for the new plugin | ||
- [ ] Add a CHANGELOG entry for the new plugin | ||
- [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml) | ||
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-booster-ui/tree/main/src/assets/img/technologies) | ||
- [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh` | ||
- [ ] Rebuild the `Plugins.md` documentation by running `make doc-gen` | ||
- [ ] I have added test cases for the feature/plugin | ||
- [ ] I have tested the added code and they work well | ||
- [ ] I have added a CHANGELOG entry for the new feature/plugin | ||
--> | ||
|
||
<!-- Additionally fill the following checklists when it's plugin-related --> | ||
- [ ] I have added a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml) | ||
- [ ] I have added a logo in [the UI repo](https://github.com/apache/skywalking-booster-ui/tree/main/src/assets/img/technologies) | ||
- [ ] I have added the library to `pyproject.toml` (plugin group) by running `poetry add library --group plugins` | ||
- [ ] I have Rebuild the `Plugins.md` documentation by running `make doc-gen` | ||
--> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributors may just fill the checklist and keep the
<!--
so these are not showing in the issue comment...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, now I suppose using the main repo's PR template will be a better choice, I added an additional plugin section there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes pushed.