Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thread propagation #62

Merged
merged 3 commits into from Aug 8, 2020
Merged

Add thread propagation #62

merged 3 commits into from Aug 8, 2020

Conversation

alonelaval
Copy link
Member

@alonelaval alonelaval commented Aug 8, 2020 •
edited

@kezhenxu94 kezhenxu94 added core feature New feature labels Aug 8, 2020
@kezhenxu94 kezhenxu94 added this to the 0.3.0 milestone Aug 8, 2020
kezhenxu94
kezhenxu94 reviewed Aug 8, 2020
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the new decorator to the doc, it'c a cool feature that the users should learn it from the doc

@alonelaval
Copy link
Member Author

Could you please add the new decorator to the doc, it'c a cool feature that the users should learn it from the doc

OK

kezhenxu94
kezhenxu94 approved these changes Aug 8, 2020
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kezhenxu94 kezhenxu94 merged commit 1c26c13 into master Aug 8, 2020
@kezhenxu94 kezhenxu94 deleted the thread-propagation branch August 8, 2020 08:25
@shuguang-dong
Copy link

hello，I have a trouble when use skywalking-python:
I learn skywalking-python by this page: https://github.com/apache/skywalking-python
after agent.start(),only create instance,but not track any request,
can you help me?
my email is dongshuguang_1993@163.com
and QQ is 709936344
thanks!

@kezhenxu94
Copy link
Member

kezhenxu94 commented Aug 10, 2020 •
edited

hello，I have a trouble when use skywalking-python:

I learn skywalking-python by this page: https://github.com/apache/skywalking-python

after agent.start(),only create instance,but not track any request,

can you help me?

my email is dongshuguang_1993@163.com

and QQ is 709936344

thanks!

What framework are you using, make sure the framework is supported in the list and there is traffic actually

@kezhenxu94
Copy link
Member

@shuguang-dong also, please open an individual issue in the main repo because your question is not related to this pull request, it confuses others in this thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees
No one assigned
Labels
core feature New feature
Projects
None yet
Milestone
0.3.0
3 participants
@alonelaval @shuguang-dong @kezhenxu94