add profile task query segment list and analyzation #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mrproliu
changed the title
wu-sheng
reviewed
Jan 31, 2020
|
After this merged, recommend you to send a separate pull request and just implement the shell of this protocol, make compiling and boot successfully. Because otherwise, it may block other PRs. |
Sure. |
wu-sheng
reviewed
Jan 31, 2020
profile.graphqls
Outdated
| # total dump count | ||
| count: Int! | ||
| # max recursion invoke count | ||
| maxRecursionCount: Int! |
There was a problem hiding this comment.
Don't recommend use this. Stack depth is limited in the agent. We could say it is safe here.
wu-sheng
reviewed
Jan 31, 2020
profile.graphqls
Outdated
| @@ -84,6 +84,28 @@ type ProfileTask { | |||
| logs: [ProfileTaskLog!]! | |||
| } | |||
|
|
|||
| # Profile thread stack anayze tree | |||
| type ThreadStackAnalyzation { | |||
wu-sheng
approved these changes
Jan 31, 2020
|
Please provide the implementation and update the submodule in the main repo. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.