Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

Feat: Support tag conditions for trace #339

Merged
merged 12 commits into from Aug 14, 2020
Merged

Conversation

Fine0830
Copy link
Member

@Fine0830 Fine0830 commented Aug 12, 2020

Support tag conditions for trace. Reference apache/skywalking#5272

Screenshots
1
2
3

Signed-off-by: Qiuxia Fan qiuxiafan@apache.org

@Fine0830 Fine0830 added the enhancement New feature or request label Aug 12, 2020
@Fine0830 Fine0830 added this to the 8.2.0 milestone Aug 12, 2020
@Fine0830 Fine0830 requested a review from wu-sheng August 12, 2020 09:44
@Fine0830 Fine0830 self-assigned this Aug 12, 2020
@wu-sheng
Copy link
Member

Please give a separate line for the tag condition, because users usually use multiple tags.

And could you show me, how to input the tag(key=vlaue)? Such as, please consider value could include white space in some cases. Traditionally, the interactive style is, user gives key=value, value could be anything following the first =. Then use enter to confirm the condition added. And you would have an x after the condition set. I think you used to do similar things in the comparison page.

@Fine0830
Copy link
Member Author

Please give a separate line for the tag condition, because users usually use multiple tags.

And could you show me, how to input the tag(key=vlaue)? Such as, please consider value could include white space in some cases. Traditionally, the interactive style is, user gives key=value, value could be anything following the first =. Then use enter to confirm the condition added. And you would have an x after the condition set. I think you used to do similar things in the comparison page.

For multiple tags, we use a separate comma. As follow,
3

@wu-sheng
Copy link
Member

The way I suggested because we don't know comma or whitespace whether be a part of tag value.

@Fine0830
Copy link
Member Author

The pr was updated, please recheck @wu-sheng

@wu-sheng wu-sheng merged commit 34f98b1 into apache:master Aug 14, 2020
@wu-sheng
Copy link
Member

@Fine0830 Please sync the main repo, I could update the demo env later.

@Fine0830 Fine0830 deleted the feat/trace branch August 14, 2020 09:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
2 participants