Fix trace id is not transmitted. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 22.16% 22.12% -0.04%
==========================================
Files 18 18
Lines 591 592 +1
==========================================
Hits 131 131
- Misses 460 461 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
So, would you like to cancel the on going release vote? This seems a critical bug. |
I think so. |
|
I added this to closed 0.4.0 release. Please notice to delete 0.4 tag carefully. |
|
The 0.4.0 tag will be set to the latest commit, if the PR is merged. |
wu-sheng
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cross process scenes, the trace id is not transmitted, by mistake in the previous modification (#39 (comment)).
The e2e is not coverd, because it dost not record trace id field.