Skip to content

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Jun 15, 2023

Add optional kafka reporter support.

  • Move CollectItemProduce and CollectItemConsume from report::grpc module to report.
  • Implement kafka reporter.
  • Update documents.
  • Add integration tests.

@jmjoy jmjoy added this to the 0.8.0 milestone Jun 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #61 (dd2ba29) into master (302526e) will decrease coverage by 2.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   16.88%   14.74%   -2.14%     
==========================================
  Files          18       20       +2     
  Lines         622      712      +90     
==========================================
  Hits          105      105              
- Misses        517      607      +90     
Impacted Files Coverage Δ
e2e/src/e2e_kafka.rs 0.00% <0.00%> (ø)
src/proto/v3/mod.rs 0.00% <ø> (ø)
src/reporter/grpc.rs 0.00% <ø> (ø)
src/reporter/kafka.rs 0.00% <0.00%> (ø)
src/reporter/mod.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmjoy jmjoy marked this pull request as ready for review June 19, 2023 10:21
@jmjoy jmjoy requested a review from wu-sheng June 19, 2023 10:22
@wu-sheng wu-sheng merged commit 84fbd00 into apache:master Jun 19, 2023
@jmjoy jmjoy deleted the kafka-reporter branch June 19, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants