Update README.md

[hanahmily]

Basic guides how to deploy swck

[wu-sheng]

@kezhenxu94 Consider adding reviewer and CI required?

[kezhenxu94]

Just one nit, otherwise LGTM.
BTW, I think the namespace is kinda of long, and verbose, because swck contains “skywalking” already :)

[hanahmily]

@wu-sheng @kezhenxu94 I intend to pick up this PR as the final collection of release 0.1.0. Pls, check what to be fixed before the release.

[wu-sheng]

@arugal As you have tested and tried locally, could do take a look of current status?

[arugal]

@hanahmily I found two problems.

1. The manager-role cannot read the services

E1107 12:14:26.309147 1 reflector.go:153] pkg/mod/k8s.io/client-go@v0.17.2/tools/cache/reflector.go:105: Failed to list *v1.Service: services is forbidden: User "system:serviceaccount:skywalking-swck-system:default" cannot list resource "services" in API group "" at the cluster scope

2. kustomize cannot modify the name of namesapce
   
   

[kezhenxu94]

@wu-sheng @kezhenxu94 I intend to pick up this PR as the final collection of release 0.1.0. Pls, check what to be fixed before the release.

If this is the last piece before 0.1.0, I noticed there are some files missing license headers, please make sure there're not distributed or add license headers for them.

[hanahmily]

@wu-sheng @kezhenxu94 I intend to pick up this PR as the final collection of release 0.1.0. Pls, check what to be fixed before the release.

If this is the last piece before 0.1.0, I noticed there are some files missing license headers, please make sure there're not distributed or add license headers for them.

Could you list what files are you talking about?

[kezhenxu94]

@wu-sheng @kezhenxu94 I intend to pick up this PR as the final collection of release 0.1.0. Pls, check what to be fixed before the release.

If this is the last piece before 0.1.0, I noticed there are some files missing license headers, please make sure there're not distributed or add license headers for them.

Could you list what files are you talking about?

https://github.com/apache/skywalking-swck/blob/master/golangci.yml
https://github.com/apache/skywalking-swck/blob/master/Dockerfile
https://github.com/apache/skywalking-swck/blob/master/PROJECT

[hanahmily]

1. kustomize cannot modify the name of namesapce
   
   

We can set namespace by cd config/default && kustomize edit set namespace <new ns> or just edit config/default/kustomization.yaml. And I mentioned how to customize it in https://github.com/apache/skywalking-swck/pull/5/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R34.

[hanahmily]

@wu-sheng @kezhenxu94 I intend to pick up this PR as the final collection of release 0.1.0. Pls, check what to be fixed before the release.

If this is the last piece before 0.1.0, I noticed there are some files missing license headers, please make sure there're not distributed or add license headers for them.

Could you list what files are you talking about?

https://github.com/apache/skywalking-swck/blob/master/golangci.yml
https://github.com/apache/skywalking-swck/blob/master/Dockerfile
https://github.com/apache/skywalking-swck/blob/master/PROJECT

Thanks, done

[wu-sheng]

@hanahmily Why these files were not detected by your script? This seems more important.

[arugal]

We can set namespace by cd config/default && kustomize edit set namespace <new ns> or just edit config/default/kustomization.yaml. And I mentioned how to customize it in https://github.com/apache/skywalking-swck/pull/5/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R34.

The namespace parameter is not valid for namespace resource.

I think that's the way it should be.

apiVersion: v1
kind: Namespace
metadata:
  labels:
    control-plane: controller-manager
  name: skywalking-swck-system

[hanahmily]

@hanahmily Why these files were not detected by your script? This seems more important.

Licenses tool only checks files in the config directory, that are updated from time to time. These files are imported, but they won't be changed once fixed.

[hanahmily]

We can set namespace by cd config/default && kustomize edit set namespace <new ns> or just edit config/default/kustomization.yaml. And I mentioned how to customize it in https://github.com/apache/skywalking-swck/pull/5/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R34.

The namespace parameter is not valid for namespace resource.

I think that's the way it should be.

apiVersion: v1
kind: Namespace
metadata:
  labels:
    control-plane: controller-manager
  name: skywalking-swck-system

My local kustomize could generate correct namespace:

 $ kustomize version
{Version:3.5.4 GitCommit:3af514fa9f85430f0c1557c4a0291e62112ab026 BuildDate:2020-01-17T14:23:25+00:00 GoOs:darwin GoArch:amd64}
 $ kustomize build config/default
apiVersion: v1
kind: Namespace
metadata:
  labels:
    control-plane: controller-manager
  name: skywalking-swck-system

I'm curious about which version your kusomize is?

and my kubectl also could get the same result:

$ kubectl version --client
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.1", GitCommit:"7879fc12a63337efff607952a323df90cdc7a335", GitTreeState:"clean", BuildDate:"2020-04-10T21:53:51Z", GoVersion:"go1.14.2", Compiler:"gc", Platform:"darwin/amd64"}
 $ kubectl kustomize config/default 
apiVersion: v1
kind: Namespace
metadata:
  labels:
    control-plane: controller-manager
  name: skywalking-swck-system
---

[arugal]

We can set namespace by cd config/default && kustomize edit set namespace <new ns> or just edit config/default/kustomization.yaml. And I mentioned how to customize it in https://github.com/apache/skywalking-swck/pull/5/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R34.

The namespace parameter is not valid for namespace resource.
I think that's the way it should be.

apiVersion: v1
kind: Namespace
metadata:
  labels:
    control-plane: controller-manager
  name: skywalking-swck-system

My local kustomize could generate correct namespace:

 $ kustomize version
{Version:3.5.4 GitCommit:3af514fa9f85430f0c1557c4a0291e62112ab026 BuildDate:2020-01-17T14:23:25+00:00 GoOs:darwin GoArch:amd64}
 $ kustomize build config/default
apiVersion: v1
kind: Namespace
metadata:
  labels:
    control-plane: controller-manager
  name: skywalking-swck-system

I'm curious about which version your kusomize is?

and my kubectl also could get the same result:

$ kubectl version --client
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.1", GitCommit:"7879fc12a63337efff607952a323df90cdc7a335", GitTreeState:"clean", BuildDate:"2020-04-10T21:53:51Z", GoVersion:"go1.14.2", Compiler:"gc", Platform:"darwin/amd64"}
 $ kubectl kustomize config/default 
apiVersion: v1
kind: Namespace
metadata:
  labels:
    control-plane: controller-manager
  name: skywalking-swck-system
---

@hanahmily Sorry, I have tested kustomize 3.8.1-3.8.4 locally and this seems to be the case only at 3.8.2.

[arugal]

Basically LGTM.

$ kubectl get all -n skywalking-swck-system

NAME                                                      READY   STATUS    RESTARTS   AGE
pod/skywalking-swck-controller-manager-6989f8cf96-gdjjp   2/2     Running   0          3h17m

NAME                                                         TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)    AGE
service/skywalking-swck-controller-manager-metrics-service   ClusterIP   10.111.142.191   <none>        8443/TCP   3h20m

NAME                                                 READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/skywalking-swck-controller-manager   1/1     1            1           3h20m

NAME                                                            DESIRED   CURRENT   READY   AGE
replicaset.apps/skywalking-swck-controller-manager-557bdff78f   0         0         0       3h20m
replicaset.apps/skywalking-swck-controller-manager-6989f8cf96   1         1         1       3h17m

$ kubectl get oapserver demo -o yaml

apiVersion: operator.skywalking.apache.org/v1alpha1
kind: OAPServer
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operator.skywalking.apache.org/v1alpha1","kind":"OAPServer","metadata":{"annotations":{},"name":"demo","namespace":"default"},"spec":{"config":[{"name":"SW_STORAGE","value":"h2"}],"instances":1,"version":"8.1.0"}}
  creationTimestamp: "2020-11-08T02:01:36Z"
  generation: 2
  name: demo
  namespace: default
  resourceVersion: "33314335"
  selfLink: /apis/operator.skywalking.apache.org/v1alpha1/namespaces/default/oapservers/demo
  uid: 490b4496-0a9c-4a33-80e8-1f3e5ba864af
spec:
  config:
  - name: SW_STORAGE
    value: h2
  image: apache/skywalking-oap-server:8.1.0-es6
  instances: 1
  version: 8.1.0
status:
  address: demo.default
  availableReplicas: 1
  conditions:
  - lastTransitionTime: "2020-11-08T02:02:51Z"
    lastUpdateTime: "2020-11-08T02:02:51Z"
    message: Deployment has minimum availability.
    reason: MinimumReplicasAvailable
    status: "True"
    type: Available
  - lastTransitionTime: "2020-11-08T02:01:36Z"
    lastUpdateTime: "2020-11-08T02:02:51Z"
    message: ReplicaSet "demo-5d6bbbbf94" has successfully progressed.
    reason: NewReplicaSetAvailable
    status: "True"
    type: Progressing

$ kubectl get all

NAME                        READY   STATUS    RESTARTS   AGE
pod/demo-5d6bbbbf94-hq879   1/1     Running   0          3h19m

NAME                 TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)               AGE
service/demo         ClusterIP   10.104.216.11   <none>        11800/TCP,12800/TCP   3h19m
service/kubernetes   ClusterIP   10.96.0.1       <none>        443/TCP               126d

NAME                   READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/demo   1/1     1            1           3h19m

NAME                              DESIRED   CURRENT   READY   AGE
replicaset.apps/demo-5d6bbbbf94   1         1         1       3h19m

[arugal]

LGTM

[wu-sheng]

Let's release our operator😀