Add keypair resource to enable access to ec2 instance #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kezhenxu94 is there anything I am missing in the process of creating an EC2 instance via Terraform? |
kezhenxu94
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Generally LGTM, some more improvements might come later after this PR:
- allow users to add more extra tags to ALL resources created by Terraform, this can be done by adding a var in variables.tf. Some enterprises enforces specific tags when creating resources in AWS, otherwise it fails weirdly.
- we can also add a variable to switch whether creating the key pair or not, this can be especially useful for new installation
|
@rabajaj0509 if you want me to merge this PR at this time and do the improvements in later PR, please let me know |
|
@kezhenxu94 Let's get this one in. I will make these improvements one at a time in the upcoming pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to enhance the provisioning process of an EC2 instance by introducing customizable variables. With this PR, users can now define their preferred configurations while creating an EC2 instance. Specifically, it ensures that users with a public key located at
~/.ssh/skywalking-terraform.pubcan successfully create an EC2 instance.