Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][javaagent][es-plugin] Optimize the handling of the xxxAsync method span #12010

Closed
2 of 3 tasks
JorringHsiao opened this issue Mar 13, 2024 · 2 comments
Closed
2 of 3 tasks

[Feature][javaagent][es-plugin] Optimize the handling of the xxxAsync method span #12010

JorringHsiao opened this issue Mar 13, 2024 · 2 comments
Labels
feature New feature good first issue Good first issue for beginners java Java agent related plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.

Comments

@JorringHsiao
Copy link

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Currently, both synchronous method (ex. org.elasticsearch.client.RestHighLevelClient#search) and asynchronous method (ex. org.elasticsearch.client.RestHighLevelClient#searchAsync) complete the span after the method call completes.

This is normal for synchronous methods, however for asynchronous methods, the elapsed time in its span is incorrect.

Use case

No response

Related issues

No response

Are you willing to submit a pull request to implement this on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct
@JorringHsiao JorringHsiao added the feature New feature label Mar 13, 2024
@wu-sheng
Copy link
Member

If you want to enhance that, you could mark span as async mode, and close in the callback.

@wu-sheng wu-sheng added plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. java Java agent related labels Mar 13, 2024
@wu-sheng
Copy link
Member

As usual, this is not covered by maintainers. Feel free to contribute.

@wu-sheng wu-sheng closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@wu-sheng wu-sheng added the good first issue Good first issue for beginners label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature good first issue Good first issue for beginners java Java agent related plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wu-sheng @JorringHsiao