Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on alarm message then jump to trace page #4407

Closed
1 of 4 tasks
ghost opened this issue Feb 24, 2020 · 8 comments
Closed
1 of 4 tasks

Click on alarm message then jump to trace page #4407

ghost opened this issue Feb 24, 2020 · 8 comments
Labels
backend OAP backend related. discussion Discussions feature New feature
Milestone

Comments

@ghost
Copy link

ghost commented Feb 24, 2020

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Question

  • What do you want to know?

Bug

  • Which version of SkyWalking, OS and JRE?

  • Which company or project?

  • What happen?
    If possible, provide a way for reproducing the error. e.g. demo application, component version.


Requirement or improvement

After SW triggers the alarm, need to manually jump to the trace page and enter related parameters to locate the trace. This is a common practice. But we can click directly to avoid the trouble of user input and optimize the user experience. This is just my personal thought, and everyone is welcome to give comments.

WX20200224-115758@2x

@ghost ghost added backend OAP backend related. feature New feature discussion Discussions labels Feb 24, 2020
@ghost ghost added this to the 7.0.0 milestone Feb 24, 2020
@ghost ghost self-assigned this Feb 24, 2020
@wu-sheng
Copy link
Member

This seems mostly on UI, who will do this?

@wu-sheng
Copy link
Member

What do you mean backend change? How do you know the alarm meaning? As user could customize the alarm rule.

@ghost
Copy link
Author

ghost commented Feb 24, 2020

What do you mean backend change? How do you know the alarm meaning? As user could customize the alarm rule.

Just want to add a link to the message, you can jump to the trace page in question, avoid manual input params. Not involved customize the alarm rule.

@wu-sheng
Copy link
Member

My point is,

  1. You tag this issue as backend, which means the OAP server. What kinds of changes are you proposing?
  2. If this is a pure link, how the UI knows the query conditions in the trace query page? I have no clue about this.

@ghost
Copy link
Author

ghost commented Feb 24, 2020

My point is,

  1. You tag this issue as backend, which means the OAP server. What kinds of changes are you proposing?
  2. If this is a pure link, how the UI knows the query conditions in the trace query page? I have no clue about this.

IMO, Extend metric including calculated start time, end time, and traceId in OAP. thus, linked Trace query page will pinpoint the problem trace.

@wu-sheng
Copy link
Member

IMO, Extend metric including calculated start time, end time, and traceId in OAP. thus, linked Trace query page will pinpoint the problem trace.

Some alarm are about the latency and other about the status. Even same about latency, it has different threshold, such as percentile. How do you know and separate them? If you can't, what is the point to jump to the trace query?

@wu-sheng
Copy link
Member

wu-sheng commented Feb 24, 2020

@Aderm In SkyWalking, if you want to propose anything, please take the design with you, including the details. It is easy to ask even implement something, but we need to make sure it is meaningful, and will be widely used. Otherwise, as such a big open source community, it will be a disaster to maintain a project with so many but not important features.

The key principle of an open source project is resolving the hardest and common problem, if there are some pre-conditions, let the users to add them in their fork even commercial versions. We are maintaining the most important core.

@ghost
Copy link
Author

ghost commented Feb 24, 2020

get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. discussion Discussions feature New feature
Projects
None yet
Development

No branches or pull requests

1 participant