Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Incorrect instance and enpoint level query implementation #5890

Closed
1 of 4 tasks
wu-sheng opened this issue Nov 25, 2020 · 4 comments · Fixed by apache/skywalking-cli#76
Closed
1 of 4 tasks

[CLI] Incorrect instance and enpoint level query implementation #5890

wu-sheng opened this issue Nov 25, 2020 · 4 comments · Fixed by apache/skywalking-cli#76
Assignees
Labels
bug Something isn't working and you are sure it's a bug! CLI Command Line Interface for SkyWalking high priority High priority issue, blocking next release.
Milestone

Comments

@wu-sheng
Copy link
Member

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Bug

image

This bug is detected, which starts with the discussion here, apache/skywalking-swck#12 (comment). The current implementation of linear(maybe more) query, doesn't adopt/use the correct parameters.

We should provide separate parameters for instance and endpoint names, with isNormal flag, which could be used in conjecture services.

@fgksgf Let's fix this and call for 0.5.0 release. Note, #4466 should follow this when you implement those queries.

@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! high priority High priority issue, blocking next release. CLI Command Line Interface for SkyWalking labels Nov 25, 2020
@wu-sheng wu-sheng added this to the CLI - 0.5.0 milestone Nov 25, 2020
@wu-sheng wu-sheng changed the title Incorrect instance and enpoint level query implementation [CLI] Incorrect instance and enpoint level query implementation Nov 25, 2020
@fgksgf
Copy link
Member

fgksgf commented Nov 25, 2020

@wu-sheng
I added a bool flag named unnormal, it's not required. Because the default value of bool is true.
If we create a isNormal flag, we probably have to add this flag most of the time.
What do you think ?

@wu-sheng
Copy link
Member Author

I added a bool flag named unnormal, it's not required. Because the default value of bool is true.
If we create a isNormal flag, we probably have to add this flag most of the time.
What do you think ?

I think this is only coding style. You could give the parameter true if no input parameter. Right? unnormal is anti-protocol, which should not be recommended.

@kezhenxu94
Copy link
Member

kezhenxu94 commented Nov 25, 2020

I added a bool flag named unnormal, it's not required. Because the default value of bool is true.
If we create a isNormal flag, we probably have to add this flag most of the time.
What do you think ?

I think this is only coding style. You could give the parameter true if no input parameter. Right? unnormal is anti-protocol, which should not be recommended.

+1, @fgksgf make isNormal type of string, and give it default value "true", and validate that it should be either "true" or "false"

@fgksgf
Copy link
Member

fgksgf commented Nov 25, 2020

Make sense to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working and you are sure it's a bug! CLI Command Line Interface for SkyWalking high priority High priority issue, blocking next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants