Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags of instance, endpoint and normal for metrics command #76

Merged
merged 9 commits into from
Nov 25, 2020
Merged

Add flags of instance, endpoint and normal for metrics command #76

merged 9 commits into from
Nov 25, 2020

Conversation

fgksgf
Copy link
Member

@fgksgf fgksgf commented Nov 25, 2020 •
edited

  • Add flags of instance, endpoint and normal for metrics command
  • Fix format issue of How-to-release.md
  • Rename the flag num to labels
  • Fix wrong examples of endpoint in README.md

Resolve apache/skywalking#5890

@fgksgf fgksgf added the bug Something isn't working label Nov 25, 2020
@fgksgf fgksgf added this to the 0.5.0 milestone Nov 25, 2020
@fgksgf
Copy link
Member Author

fgksgf commented Nov 25, 2020

It's weird, failed to build, but I can build it successfully on my pc.

@wu-sheng
Copy link
Member

Read this #74

kezhenxu94
kezhenxu94 reviewed Nov 25, 2020
View reviewed changes
assets/assets.gen.go Outdated Show resolved Hide resolved
@fgksgf fgksgf marked this pull request as ready for review November 25, 2020 07:32
@fgksgf fgksgf marked this pull request as draft November 25, 2020 07:49
@codecov-io
Copy link

codecov-io commented Nov 25, 2020 •
edited

Codecov Report

Merging #76 (8ed31d8) into master (88b1874) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   51.56%   51.56%           
=======================================
  Files           9        9           
  Lines         128      128           
=======================================
  Hits           66       66           
  Misses         54       54           
  Partials        8        8
Impacted Files Coverage Δ
commands/interceptor/scope.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b1874...8ed31d8. Read the comment docs.

@fgksgf fgksgf marked this pull request as ready for review November 25, 2020 08:17
kezhenxu94
kezhenxu94 previously approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wu-sheng @hanahmily please recheck

hanahmily
hanahmily reviewed Nov 25, 2020
View reviewed changes
README.md Show resolved Hide resolved
@hanahmily
Copy link
Contributor

LGTM, except for the name of multi-line metrics' label.

wu-sheng
wu-sheng reviewed Nov 25, 2020
View reviewed changes
README.md Show resolved Hide resolved
@kezhenxu94 kezhenxu94 mentioned this pull request Nov 25, 2020
Merged
@kezhenxu94 kezhenxu94 merged commit ffee47d into apache:master Nov 25, 2020
@fgksgf fgksgf deleted the fix branch November 26, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanahmily hanahmily hanahmily left review comments

@kezhenxu94 kezhenxu94 kezhenxu94 left review comments

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.0
5 participants
@fgksgf @wu-sheng @codecov-io @hanahmily @kezhenxu94