Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some new thread metric and class metric to JVMMetric #7230

Closed
1 task done
Switch-vov opened this issue Jul 2, 2021 · 2 comments · Fixed by #7243
Closed
1 task done

Add some new thread metric and class metric to JVMMetric #7230

Switch-vov opened this issue Jul 2, 2021 · 2 comments · Fixed by #7243
Labels
protocol agent->collector or UI->collector protocols related.
Milestone

Comments

@Switch-vov
Copy link
Contributor

Switch-vov commented Jul 2, 2021

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Feature or performance improvement

Requirement or improvement

Add some new thread metric and class metric to JVMMetric.

Protocal

message JVMMetric {
    int64 time = 1;
    CPU cpu = 2;
    repeated Memory memory = 3;
    repeated MemoryPool memoryPool = 4;
    repeated GC gc = 5;
    Thread thread = 6;
    Class clazz = 7;
}

message Thread {
    int64 liveCount = 1;
    int64 daemonCount = 2;
    int64 peakCount = 3;
    // new metric
    int64 newStateThreadCount = 4;
    int64 runnableStateThreadCount = 5;
    int64 blockedStateThreadCount = 6;
    int64 waitingStateThreadCount = 7;
    int64 timedWaitingStateThreadCount = 8;
    int64 terminatedStateThreadCount = 9;
}

// new metric
message Class {
    int64 loadedClassCount = 1;
    int64 totalUnloadedClassCount = 2;
    int64 totalLoadedClassCount = 3;
}

The result in skywalking ui

image
image

@wu-sheng
Copy link
Member

wu-sheng commented Jul 2, 2021

You could send pull request to data-collect-protocol repo, we could check details there.

@wu-sheng wu-sheng added the protocol agent->collector or UI->collector protocols related. label Jul 2, 2021
Switch-vov added a commit to Switch-vov/skywalking that referenced this issue Jul 2, 2021
@Switch-vov
Copy link
Contributor Author

You could send pull request to data-collect-protocol repo, we could check details there.

ok. I'm trying to send PR.

Switch-vov added a commit to Switch-vov/skywalking that referenced this issue Jul 5, 2021
Switch-vov added a commit to Switch-vov/skywalking that referenced this issue Jul 5, 2021
Switch-vov added a commit to Switch-vov/skywalking that referenced this issue Jul 5, 2021
Switch-vov added a commit to Switch-vov/skywalking that referenced this issue Jul 5, 2021
@Switch-vov Switch-vov changed the title add some new thread metric and class metric to JVMMetric Add some new thread metric and class metric to JVMMetric Jul 5, 2021
Switch-vov added a commit to Switch-vov/skywalking that referenced this issue Jul 5, 2021
Switch-vov added a commit to Switch-vov/skywalking that referenced this issue Jul 6, 2021
Switch-vov added a commit to Switch-vov/skywalking that referenced this issue Jul 7, 2021
Switch-vov added a commit to Switch-vov/skywalking that referenced this issue Jul 7, 2021
@wu-sheng wu-sheng added this to the 8.7.0 milestone Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol agent->collector or UI->collector protocols related.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants