Support cross thread trace profiling #10575
Conversation
mrproliu
added
submodule update
|
Is this going to break UI temporarily, right? |
Yes, It need the UI to adapt with the new query protocol. |
|
FYI @apache/skywalking-committers After this gets merged, we are going to hold the demo update until we have UI side adoption. Otherwise, the profiling relative features are broken. |
| @@ -92,6 +93,14 @@ public IntValues getLinearIntValues(final MetricCondition metrics, | |||
| return metricsValues.getValues(); | |||
| } | |||
|
|
|||
| public NullableValue readNullableMetricsValue(MetricsCondition condition, Duration duration) { | |||
| // TODO default implantation | |||
...main/java/org/apache/skywalking/oap/server/core/profiling/trace/ProfileTaskQueryService.java
Show resolved
Hide resolved
BTW, as @Fine0830 almost finished apache/skywalking-booster-ui#243 topology), I would like to merge that first and make an update for demo. |
|
@mrproliu There is a snapshot exporter tool. Do we need some update about that? |
The tools have been updated to support multiple segments. If users want to use them, they need to update them too. |
|
Is there anything expected to change for https://skywalking.apache.org/docs/main/next/en/guides/backend-profile-export/? Notice, the profiling docs should be moved from contribute doc to new profiling doc. https://skywalking.apache.org/docs/main/next/en/guides/readme/#profile |
No, this file only descript how to use this export tool, and the usage has no change.
Yes, I will write the documentation for cross-thread trace profiling and continuous profiling. |
Following #10373, support the query of the cross thread trace profiling.
Also, the
readNullableMetricsValuequery been added with default implementation, this should be update in other PR.CHANGESlog.