Support isEmptyValue flag for metrics query. #10616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y zero or no data. Fix `NPE` when query the not exist series indexes in ElasticSearch storage
wankai123
added
bug
kezhenxu94
reviewed
Mar 30, 2023
wu-sheng
reviewed
Mar 30, 2023
...rver-core/src/main/java/org/apache/skywalking/oap/server/core/query/MetricsQueryService.java
Show resolved
Hide resolved
wu-sheng
approved these changes
Mar 30, 2023
kezhenxu94
added a commit
to kezhenxu94/skywalking
that referenced
this pull request
Jul 14, 2023
kezhenxu94
added a commit
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And Fix
NPEwhen query the not exist series indexes in ElasticSearch storage.If this is non-trivial feature, paste the links/URLs to the design doc.
Update the documentation to include this new feature.
Tests(including UT, IT, E2E) are added to verify the new feature.
If it's UI related, attach the screenshots below.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes [Feature] Support isEmptyValue flag for metrics query #10501.
Update the
CHANGESlog.