Use listening mode for apollo configuration. #11186
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
I made this change, now oap can receive apollo changes immediately after it update:
|
|
If you change config mode, you should change the cluster coordinator as well? |
Cluster already works in listening mode, this feature is inspired by cluster module too. |
| @@ -471,7 +471,6 @@ configuration: | |||
| apolloCluster: ${SW_CONFIG_APOLLO_CLUSTER:default} | |||
| apolloEnv: ${SW_CONFIG_APOLLO_ENV:""} | |||
| appId: ${SW_CONFIG_APOLLO_APP_ID:skywalking} | |||
| period: ${SW_CONFIG_APOLLO_PERIOD:60} | |||
There was a problem hiding this comment.
Can you remove this too in the configuration doc?
listening mode
If this is non-trivial feature, paste the links/URLs to the design doc.
Update the documentation to include this new feature.
Tests(including UT, IT, E2E) are added to verify the new feature.
If it's UI related, attach the screenshots below.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes Use long polling in apollo configuration module. #11180.
Update the
CHANGESlog.