Reorganize the receiver proto #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
commented
Mar 30, 2019
| } | ||
|
|
||
| service CollectorService { | ||
| rpc PostSpans(PostSpansRequest) returns (PostSpansResponse) { |
There was a problem hiding this comment.
@yurishkuro This is the entrance grpc method of jaeger spans, right? All span should be collected through this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, besides the skywalking native formats(protos), now we have a lot of proto files from envoy, istio, gogo etc. Right now, we keep them in different receiver, which make some common proto files duplicate, such as gogoproto or google/api.
In this PR, I move all of them in to
receiver-protoand make sure there is the only copy of each proto.And, I added jaeger collector grpc proto and it dependency in, with LICENSE file changed/added.