-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting RequestRateLimiterGatewayFilterFactory #3538
Conversation
@xiaoy00 Could you provide demo codes about this? |
The current gateway test demo, it would be better to enrich this case here. |
I have already submitted the case on gateway test demo, please have a look |
Hi @xiaoy00 , Please modify the code according to code style and modify testcase so that test cases can work. |
|
Fix gateway-2.1.x-plugin according to code style. |
|
You should verify style by maven command. It is what we used on CI. Also, click details link, we have the logs. |
The referred demo is integratuon test, you need to read the plugin tests document and change the codes, then make tests passed. In open source, we need to make sure cases are checked in any further changes. But not just your local tests. |
.../optional-plugins/optional-spring-plugins/optional-spring-cloud/gateway-2.1.x-plugin/pom.xml
Show resolved
Hide resolved
#3603 merged. Please continue. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many filed not under Apache 2.0 license. So CI fail with rat check unpassed. Please fix.
@zhaoyuguang Please review the code changes.
Resolve the conflicts, please. |
/run agent-plugin-test-3 |
/run agent-plugin-test-3 |
/run agent-plugin-test-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cast to approve as @zhaoyuguang approved.
Please answer these questions before submitting pull request
Why submit this pull request?
[1] Bug fix
New feature provided
Improve performance
Related issues
no
Bug fix
Bug description.
when i use the RequestRateLimiterGatewayFilterFactory for limit.
then ContextManager.capture() can not work in NettyRoutingFilterInterceptor.class
because Thread is changed from 'reactor-http-nio' to 'lettuce-nioEventLoop'
How to fix?
get ContextSnapshot on FilteringWebHandlerInterceptor and set it into SWTransmitter.
then NettyRoutingFilterInterceptor can use ContextSnapshot to ContextManager.continued(swTransmitter.getSnapshot());
and i have to create a new LocalSpan for bring ContextManager.continued() worked
New feature or improvement