Support dynamically configure alarm settings #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhenxu94
added
core feature
wu-sheng
reviewed
Oct 2, 2019
|
CI failing? I am going to review this tomorrow. |
wu-sheng
reviewed
Oct 5, 2019
There was a problem hiding this comment.
According to the document, I would suggest we need to update document
- New dynamic settings for alarm.
- Alarm cached data will be lost if alarm rule changes. Such as changing period from 5 to 10, will make last 5 mins cache data lost. This makes the alarm cache data started now.
wu-sheng
reviewed
Oct 5, 2019
...in/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRulesWatcher.java
Show resolved
Hide resolved
wu-sheng
reviewed
Oct 5, 2019
.../src/test/java/org/apache/skywalking/oap/server/core/alarm/provider/WebhookCallbackTest.java
Outdated
Show resolved
Hide resolved
Fix potential CI failure
wu-sheng
reviewed
Oct 5, 2019
wu-sheng
reviewed
Oct 5, 2019
wu-sheng
approved these changes
Oct 5, 2019
|
Thank you very much!We really need this feature！ |
|
Thank you very much! @kezhenxu94 @wu-sheng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
closes #3467