Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code cleanup: remove unnecessary and optimize the function's parameters. #3577

Merged
merged 3 commits into from
Oct 9, 2019
Merged

code cleanup: remove unnecessary and optimize the function's parameters. #3577

merged 3 commits into from
Oct 9, 2019

Conversation

JaredTan95
Copy link
Member

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

@JaredTan95 JaredTan95 added this to the 6.5.0 milestone Oct 8, 2019
@JaredTan95 JaredTan95 added feature New feature backend OAP backend related. submodule update Change submodule commit ID, including network protocol, query GraphQL and UI query OAP query protocol related and removed submodule update Change submodule commit ID, including network protocol, query GraphQL and UI labels Oct 8, 2019
@JaredTan95 JaredTan95 requested review from wu-sheng and peng-yongsheng and removed request for wu-sheng October 8, 2019 13:02
kezhenxu94
kezhenxu94 previously requested changes Oct 8, 2019
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check code styles

@kezhenxu94 kezhenxu94 dismissed their stale review October 8, 2019 13:25

Goops, my eyes blur just now

@JaredTan95
Copy link
Member Author

Weird~, I will test in my local env.

@kezhenxu94
Copy link
Member

You remove some throws exception, I guess there're unused imports

@kezhenxu94
Copy link
Member

the e2e keeps failing, need to inspect more why

@JaredTan95
Copy link
Member Author

/run e2e

wu-sheng
wu-sheng approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 2db2638 into master Oct 9, 2019
@JaredTan95 JaredTan95 deleted the code_cleanup branch October 9, 2019 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@kezhenxu94 kezhenxu94 kezhenxu94 left review comments

@peng-yongsheng peng-yongsheng Awaiting requested review from peng-yongsheng

Assignees
No one assigned
Labels
backend OAP backend related. feature New feature query OAP query protocol related
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JaredTan95 @kezhenxu94 @wu-sheng