Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test/plugin]Improves script #3579

Merged
merged 1 commit into from
Oct 9, 2019
Merged

[test/plugin]Improves script #3579

merged 1 commit into from
Oct 9, 2019

Conversation

dmsolr
Copy link
Member

@dmsolr dmsolr commented Oct 9, 2019

Please answer these questions before submitting pull request

  • Why submit this pull request?
  • Bug fix
  • New feature provided
  • Improve performance

New feature or improvement

  • Describe the details and related test reports.

Improves plugin-test execution script.

  1. add usage
  2. support to build plugin-test tools with argument '-f'
  3. support to SkyWalking Agent when it not exists


if [[ ! -d ${agent_home} ]]; then
echo "[WARN] SkyWalking Agent not exists"
${mvnw} -f ${home}/../../pom.xml -Pagent -DskipTests clean package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you trying to build agent jar if the prev step didn't execute?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
It is trigger only when it run local.

@wu-sheng wu-sheng added this to the 6.5.0 milestone Oct 9, 2019
@wu-sheng wu-sheng added feature New feature test Test requirements about performance, feature or before release. labels Oct 9, 2019
@wu-sheng wu-sheng merged commit 002a161 into apache:master Oct 9, 2019
@dmsolr dmsolr deleted the test/script branch October 9, 2019 06:56
@dmsolr dmsolr mentioned this pull request Oct 10, 2019
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature test Test requirements about performance, feature or before release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants