Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test/plugin] immigrate dubbo scenario #3590

Merged
merged 12 commits into from
Oct 12, 2019
Merged

[test/plugin] immigrate dubbo scenario #3590

merged 12 commits into from
Oct 12, 2019

Conversation

arugal
Copy link
Member

@arugal arugal commented Oct 10, 2019 •
edited
Loading

Please answer these questions before submitting pull request

New feature or improvement

  • Describe the details and related test reports.

@wu-sheng wu-sheng added agent Language agent related. plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. test Test requirements about performance, feature or before release. labels Oct 10, 2019
@wu-sheng wu-sheng added this to the 6.5.0 milestone Oct 10, 2019
@wu-sheng
Copy link
Member

FYI @dmsolr

@arugal
Copy link
Member Author

arugal commented Oct 10, 2019

When #3584 is finished with me, I will modify to jvm-container

@arugal arugal mentioned this pull request Oct 10, 2019
Closed
50 tasks
@wu-sheng
Copy link
Member

#3584 merged, you are good to go.

wu-sheng
wu-sheng reviewed Oct 12, 2019
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed to add test case number for jetty. Please add them when you change the tests to JVM container based.

@wu-sheng wu-sheng mentioned this pull request Oct 12, 2019
Merged
3 tasks
@arugal arugal changed the title [WIP][test/plugin] immigrate dubbo scenario [test/plugin] immigrate dubbo scenario Oct 12, 2019
@arugal
Copy link
Member Author

arugal commented Oct 12, 2019

@wu-sheng @kezhenxu94 @zhaoyuguang @ascrutae please review

wu-sheng
wu-sheng approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool. I am adding this fast. I am assuming this test case tool is better than the old one.

Great work @dmsolr

@wu-sheng wu-sheng merged commit e2216c8 into apache:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 left review comments

@wu-sheng wu-sheng wu-sheng approved these changes

@ascrutae ascrutae Awaiting requested review from ascrutae

@zhaoyuguang zhaoyuguang Awaiting requested review from zhaoyuguang

Assignees
No one assigned
Labels
agent Language agent related. plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. test Test requirements about performance, feature or before release.
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arugal @wu-sheng @kezhenxu94