Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make query max window size configurable. #3765

Merged
merged 2 commits into from
Nov 1, 2019
Merged

make query max window size configurable. #3765

merged 2 commits into from
Nov 1, 2019

Conversation

JaredTan95
Copy link
Member

@JaredTan95 JaredTan95 commented Nov 1, 2019

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

After merged pr #3748


Bug fix

  • Bug description.

Skywalking OAP updateNetworkAddressInventory and ServiceInventory will cause exceptions as follows:

Caused by: org.elasticsearch.client.ResponseException: method [POST], host [http://localhost:9200], URI [/network_address_inventory/type/_search?typed_keys=true&ignore_unavailable=false&expand_wildcards=open&allow_no_indices=true&search_type=query_then_fetch&batched_reduce_size=512], status line [HTTP/1.1 500 Internal Server Error]
{"error":{"root_cause":[{"type":"query_phase_execution_exception","reason":"Result window is too large, from + size must be less than or equal to: [10000] but was [2147483647]. See the scroll api for a more efficient way to request large data sets. This limit can be set by changing the [index.max_result_window] index level setting."}],
  • How to fix?

The reason is that elasticsearch window size is10000 default. If we do not modify elasticseach.yml.
We can adjust this size in configuration and set 10000 as default value.


New feature or improvement

  • Describe the details and related test reports.

@JaredTan95 JaredTan95 added bug Something isn't working and you are sure it's a bug! feature New feature backend OAP backend related. labels Nov 1, 2019
@JaredTan95 JaredTan95 added this to the 6.5.0 milestone Nov 1, 2019
@wu-sheng
Copy link
Member

wu-sheng commented Nov 1, 2019

Could we make it in the configuration and 10k as default?

@JaredTan95 JaredTan95 changed the title fix elasticsearch query data window size too large error. ake query max window size configurable. Nov 1, 2019
@JaredTan95 JaredTan95 changed the title ake query max window size configurable. make query max window size configurable. Nov 1, 2019
@wu-sheng wu-sheng merged commit fbabcb1 into master Nov 1, 2019
@wu-sheng wu-sheng deleted the max_size branch November 1, 2019 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. bug Something isn't working and you are sure it's a bug! feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants