-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SupplierWrapper to support java 1.8+ CompletableFuture.supplyAsync #3779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shixiang <xiang.shi001@bkjk.com>
Signed-off-by: shixiang <xiang.shi001@bkjk.com>
sxzaihua
commented
Nov 4, 2019
@@ -40,6 +40,7 @@ | |||
private static final String CALL_METHOD_INTERCEPTOR = "org.apache.skywalking.apm.toolkit.activation.trace.CallableOrRunnableInvokeInterceptor"; | |||
private static final String CALL_METHOD_NAME = "call"; | |||
private static final String RUN_METHOD_NAME = "run"; | |||
private static final String GET_METHOD_NAME = "get"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
support Supplier
...in/java/org/apache/skywalking/apm/toolkit/activation/trace/CallableOrRunnableActivation.java
Show resolved
Hide resolved
add SupplierWrapper to support java 1.8+ CompletableFuture.supplyAsync #3776 |
|
@sxzaihua This PR closed for? |
add a new request pull
| |
sxzaihua
|
|
sxzaihua@163.com
|
签名由网易邮箱大师定制
On 11/5/2019 10:13,吴晟 Wu Sheng<notifications@github.com> wrote:
@sxzaihua This PR closed for?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
wu-sheng
pushed a commit
that referenced
this pull request
Nov 6, 2019
…#3779 (#3783) * add SupplierWrapper to support java 1.8+ Signed-off-by: shixiang <xiang.shi001@bkjk.com> * add SupplierWrapper to support java 1.8+ Signed-off-by: shixiang <xiang.shi001@bkjk.com> * Update SupplierWrapper.java add new line * add supplier * add supplier test * add test * add test yaml * Update Application-toolkit-trace-cross-thread.md Add how to use SupplierWrapper in Java 1.8+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add SupplierWrapper to support java 1.8+ CompletableFuture.supplyAsync #3776
#3776