Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SupplierWrapper to support java 1.8+ CompletableFuture.supplyAsync #3779

Closed
wants to merge 5 commits into from

Conversation

sxzaihua
Copy link
Contributor

@sxzaihua sxzaihua commented Nov 4, 2019

add SupplierWrapper to support java 1.8+ CompletableFuture.supplyAsync #3776
#3776

shixiang added 2 commits November 4, 2019 17:21
Signed-off-by: shixiang <xiang.shi001@bkjk.com>
Signed-off-by: shixiang <xiang.shi001@bkjk.com>
@@ -40,6 +40,7 @@
private static final String CALL_METHOD_INTERCEPTOR = "org.apache.skywalking.apm.toolkit.activation.trace.CallableOrRunnableInvokeInterceptor";
private static final String CALL_METHOD_NAME = "call";
private static final String RUN_METHOD_NAME = "run";
private static final String GET_METHOD_NAME = "get";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support Supplier

@wu-sheng wu-sheng added agent Language agent related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. TBD To be decided later, need more discussion or input. labels Nov 4, 2019
@sxzaihua
Copy link
Contributor Author

sxzaihua commented Nov 4, 2019

add SupplierWrapper to support java 1.8+ CompletableFuture.supplyAsync #3776

@wu-sheng
Copy link
Member

wu-sheng commented Nov 4, 2019

  1. Use description rather than issue NO. as title
  2. You are facing compiling errors. Please fix it.

@sxzaihua sxzaihua changed the title 3776 add SupplierWrapper to support java 1.8+ CompletableFuture.supplyAsync Nov 4, 2019
@sxzaihua sxzaihua closed this Nov 5, 2019
@wu-sheng
Copy link
Member

wu-sheng commented Nov 5, 2019

@sxzaihua This PR closed for?

@sxzaihua
Copy link
Contributor Author

sxzaihua commented Nov 5, 2019 via email

wu-sheng pushed a commit that referenced this pull request Nov 6, 2019
…#3779 (#3783)

* add SupplierWrapper to support java 1.8+

Signed-off-by: shixiang <xiang.shi001@bkjk.com>

* add SupplierWrapper to support java 1.8+

Signed-off-by: shixiang <xiang.shi001@bkjk.com>

* Update SupplierWrapper.java

add new line

* add supplier

* add supplier test

* add test

* add test yaml

* Update Application-toolkit-trace-cross-thread.md

Add how to use SupplierWrapper in Java 1.8+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. TBD To be decided later, need more discussion or input.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants