Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spring annotation inheritance problem #3847 #3886

Merged
merged 5 commits into from
Nov 19, 2019

Conversation

carrypann
Copy link
Contributor

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues
    #3847


Bug fix

  • Bug description.
    Method with @RequestMapping or other restful mapping annotations declared in interface or super class can not be enhanced by skywalking.
  • How to fix?
    Use AnnotationUtils in Spring framework to get annotation.

@wu-sheng wu-sheng added agent Language agent related. bug Something isn't working and you are sure it's a bug! plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. labels Nov 18, 2019
@wu-sheng
Copy link
Member

@candyleer do you have time to review?

@wu-sheng wu-sheng closed this Nov 18, 2019
@wu-sheng wu-sheng reopened this Nov 18, 2019
Copy link
Member

@dmsolr dmsolr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to me.

@wu-sheng wu-sheng added this to the 6.6.0 milestone Nov 19, 2019
@apache apache deleted a comment from arugal Nov 19, 2019
Copy link
Member

@candyleer candyleer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 7e889d3 into apache:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. bug Something isn't working and you are sure it's a bug! plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants