[test/plugin] immigrate test hystrix scenario. #3887
Conversation
dmsolr
added
plugin
| scenario name | versions | elapsed time (sec) | ||
| ---|---|--- | ||
| hystrix-scenario | 20 | 799.00 |
There was a problem hiding this comment.
place it in Workload1 Group2. Because the group1 also takes almost 3000s.
There was a problem hiding this comment.
Before I modified, According to Plugin-test.md, workload3 group1 is little faster than workload1 Group 2
There was a problem hiding this comment.
I see. But a workload is waiting for both groups to finish, two groups of workload take the same time will be better.
There was a problem hiding this comment.
if add to workload1 group2，total is：3090.98. current workload3 group1， total is: 3090.912， is right？
There was a problem hiding this comment.
@Aderm According to document, workload1 group2 is only 2300s. Much faster than 3000. Where is your data from?
Also verified from the CI process, https://builds.apache.org/blue/organizations/jenkins/skywalking-agent-test/detail/skywalking-agent-test/1297/pipeline/135
There was a problem hiding this comment.
I mean :
current: workload1 group2(2291.98s)
current: workload3 group1(2291.912s)
If you follow the fasterer, you should choose workload3 group1
799 is hystrix-scenario time
3090.98= 2291.98+799 (if put on workload1 group2)
3090.912= 2291.912+799 (if put on workload3 group1)
The total is as a comparison, there is no other meaning
.../hystrix-scenario/src/main/java/test/apache/skywalking/apm/testcase/hystrix/Application.java
Outdated
Show resolved
Hide resolved
...rio/src/main/java/test/apache/skywalking/apm/testcase/hystrix/controller/CaseController.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| protected String run() throws Exception { | ||
| Thread.sleep(2001); |
There was a problem hiding this comment.
Usually, I don't recommend to do that. If have to do, I think it doesn't over 1000ms. (Personal suggestion)
There was a problem hiding this comment.
Because it is easy to cause by timeout. WDYT, @arugal
There was a problem hiding this comment.
Maybe understand a little bit different, this logic is to trigger the timeout fuse, now the fuse time is 1s
There was a problem hiding this comment.
I mean that the request(/hystrix-scenario) timeout so that test failures. before Hystrix works. So that we will get the unexpected data.
There was a problem hiding this comment.
This setting does not affect, although sleep 2s in run method, the front end rest request hystrix will returns fallback result when run over 1s.
There was a problem hiding this comment.
For triggering fusing. @wu-sheng
There was a problem hiding this comment.
OK, if fusing in the case, then make sense.
There was a problem hiding this comment.
This is because there is a hystrix blown test scene.
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
refer Plugin test-cases immigrate plan #3583
Bug fix
Bug description.
How to fix?
New feature or improvement