Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ordered segment list in trace query #3906

Merged
merged 3 commits into from
Nov 20, 2019
Merged

Support ordered segment list in trace query #3906

merged 3 commits into from
Nov 20, 2019

Conversation

wu-sheng
Copy link
Member

Please answer these questions before submitting pull request

Bug fix

  • Bug description.
    In some cases, there are segment fragments, which could not be linked by Ref,
    because of two kinds of reasons.
  1. Multiple leaf segments have no particular order in the storage.
  2. Lost in sampling, agent fail safe, segment lost, even bug.
  • How to fix?
    Sorting the segments makes the trace view more readable.

@bnubobby Is this fixing your issue?

@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! backend OAP backend related. labels Nov 20, 2019
@wu-sheng wu-sheng added this to the 6.6.0 milestone Nov 20, 2019
kezhenxu94
kezhenxu94 previously approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit, does no harm

...server-core/src/main/java/org/apache/skywalking/oap/server/core/query/TraceQueryService.java Outdated Show resolved Hide resolved
@wu-sheng wu-sheng merged commit 0724cdb into master Nov 20, 2019
@wu-sheng wu-sheng deleted the segment-order branch November 20, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredTan95 JaredTan95 JaredTan95 approved these changes

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@dmsolr dmsolr dmsolr approved these changes

Assignees
No one assigned
Labels
backend OAP backend related. bug Something isn't working and you are sure it's a bug!
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.

What is the order defining for Segment at the same level ?
4 participants
@wu-sheng @JaredTan95 @kezhenxu94 @dmsolr