Add jetty's Java agent deployment instructions #3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add Java agent deployment instructions for skywalking with jetty and resin
wu-sheng
added
the
documentation
|
You should change the PR title and description to fit what your PR does. |
wu-sheng
reviewed
Nov 20, 2019
|
|
||
|
|
||
| - Jetty | ||
| Modify `jetty.sh`. |
There was a problem hiding this comment.
From the review page, https://github.com/apache/skywalking/blob/ad70d42674fc5d7c1448a415948a49043010d60a/docs/en/setup/service-agent/java-agent/README.md
The format is not right. Please fix.
Add java agent deployment document for skywalking with jetty
|
@songzhendong please change the title to describe what you're doing in this pull request, it helps the reviewers to understand your motivation, and the title will serve as the commit message (by default) when merging into master, besides, it's going to be our release note in the next version
|
songzhendong
changed the title
wu-sheng
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
Add Java agent deployment instructions for skywaking with jetty
Bug fix
Bug description.
How to fix?
New feature or improvement