Document error for agent config file 's config description #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logging.dir 's Description is an Error .Default value is not System.out. It is a dir.
logging.dir 's Description is an Error .Default value is not System.out. It is a dir.
Update README.md
seifeHu
changed the title
seifeHu
commented
Nov 27, 2019
| @@ -93,7 +93,7 @@ property key | Description | Default | | |||
| `logging.level`|The log level. Default is debug.|`DEBUG`| | |||
| `logging.file_name`|Log file name.|`skywalking-api.log`| | |||
| `logging.output`| Log output. Default is FILE. Use CONSOLE means output to stdout. |`FILE`| | |||
| `logging.dir`|Log files directory. Default is blank string, means, use "system.out" to output logs.|`""`| | |||
| `logging.dir`|Log files directory. Default is blank string, means, use "{theSkywalkingAgentJarDir}/logs " to output logs. {theSkywalkingAgentJarDir} is the directory where the skywalking agent jar file is located |`""`| | |||
There was a problem hiding this comment.
the description is an Error .In fact, the log will be output to the "agentJarDir/logs "
|
The class comment is wrong too, org.apache.skywalking.apm.agent.core.conf.Config#Logging#DIR. Could you fix this too? |
wu-sheng
added
bug
the comments is an Error . fix it .
ok . I pull an other pull request |
wu-sheng
approved these changes
Nov 27, 2019
|
This one is good, you don't need a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Documents Error In v6.5 ? #3942
In
https://github.com/apache/skywalking/blob/v6.5.0/docs/en/setup/service-agent/java-agent/README.md