Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip unnecessary action #3973

Merged
merged 3 commits into from
Nov 29, 2019
Merged

skip unnecessary action #3973

merged 3 commits into from
Nov 29, 2019

Conversation

dmsolr
Copy link
Member

@dmsolr dmsolr commented Nov 29, 2019

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues


New feature or improvement

  • Describe the details and related test reports.

To skip Github Action when it is unnecessary.

@dmsolr dmsolr added the CI settings CI settings adjustment label Nov 29, 2019
@dmsolr dmsolr added this to the 6.6.0 milestone Nov 29, 2019
@dmsolr dmsolr requested a review from wu-sheng November 29, 2019 06:58
wu-sheng
wu-sheng previously approved these changes Nov 29, 2019
wu-sheng
wu-sheng previously approved these changes Nov 29, 2019
@wu-sheng
Copy link
Member

Skip successfully.

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add skip condition to the other checks

@wu-sheng
Copy link
Member

Why not add skip condition to the other checks

Because I required the required check. In GitHub Action, if skip happens, it never shows as passed :)

@wu-sheng wu-sheng merged commit 244ec55 into apache:master Nov 29, 2019
@dmsolr dmsolr deleted the pr/actions branch February 14, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI settings CI settings adjustment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants