Remove the local/exit span register mechanism in Java agent scenario #4059
Conversation
wu-sheng
added
core feature
|
We include exit span in the plugin test cases, I have to remove them one by one, sadly.... |
Codecov Report
@@ Coverage Diff @@
## master #4059 +/- ##
==========================================
- Coverage 26.85% 26.82% -0.04%
==========================================
Files 1134 1134
Lines 24980 24986 +6
Branches 3601 3607 +6
==========================================
- Hits 6709 6703 -6
- Misses 17674 17686 +12
Partials 597 597
Continue to review full report at Codecov.
|
|
@dmsolr @wayilau @arugal I already updated the plugin test document and existing plugin test cases. Please review this PR too. If this PR could pass @kezhenxu94 and @ascrutae 's local tests, I would like to merge this ASAP, due to it affects all potential and existing plugin test PRs. |
|
FYI @cyejing |
| .setFrom(endpoint.getFrom())); | ||
| } | ||
| } else { | ||
| logger.warn("Unexpected endpoint register, endpoint isn't detected from server side. {}", request); |
There was a problem hiding this comment.
To all reviewers, this needs to be added into changelog and FAQ, as people may face a lot of these logs when agents have not upgraded. What do you think?
There was a problem hiding this comment.
I just submit a commit to do this. please recheck.
|
@kezhenxu94 @ascrutae All tests passed, but I think you should run a local test to re-verify. |
|
@wu-sheng Hi, |
You could recheck. In my mind, all other agents and SDK are not using register at the SDK side. |
Checked, |
There was a problem hiding this comment.
@kezhenxu94 Could you review and run a test locally? Especially for the plugin you are working on, Runnable case I mean. If inside runnable, an RPC is called, the endpoint dependency should show that endpoint still depends on the parent endpoint(RPC in the parent thread of the runnable).
Checked, LGTM
Resolves #4056
Key, reduce the load of register and amount of operation id. Also, reduce the agent memory cost.
At the same time, the local span and exit span plugins will not concern about
parameter in the op namecausingtoo many registersissue.@kezhenxu94 Could you review and run a test locally? Especially for the plugin you are working on,
Runnablecase I mean. If insiderunnable, an RPC is called, the endpoint dependency should show that endpoint still depends on the parent endpoint(RPC in the parent thread of the runnable). If no parent thread exist, as this thread is a local task(timer), then the endpoint should depend on the user. Could you verify these two cases? And confirm no local span and exit span register happen, check throughUnexpected endpoint register, endpoint isn't detected from server side.,happens.