Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve skywalking-deploy.sh #4064

Merged
merged 2 commits into from Dec 15, 2019
Merged

Improve skywalking-deploy.sh #4064

merged 2 commits into from Dec 15, 2019

Conversation

arugal
Copy link
Member

@arugal arugal commented Dec 14, 2019

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues


Bug fix

  • Bug description.

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

@wu-sheng wu-sheng added this to the 6.6.0 milestone Dec 14, 2019
@wu-sheng wu-sheng added the CI settings CI settings adjustment label Dec 14, 2019
Copy link
Member

@innerpeacez innerpeacez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov-io
Copy link

Codecov Report

Merging #4064 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4064   +/-   ##
=======================================
  Coverage   26.85%   26.85%           
=======================================
  Files        1134     1134           
  Lines       24980    24980           
  Branches     3601     3601           
=======================================
  Hits         6709     6709           
  Misses      17674    17674           
  Partials      597      597

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0513dd8...46e6d1c. Read the comment docs.

@wu-sheng wu-sheng merged commit 23311ca into apache:master Dec 15, 2019
@arugal arugal deleted the patch1 branch December 15, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI settings CI settings adjustment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants