-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide config stream processor #4133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add comments to all classes. For all new core classes, this should be done.
Most codes are good, just one question about IConfigDAO
.
@kezhenxu94 @dmsolr @wayilau @arugal Any interest to follow this PR?
...rver/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/IConfigDAO.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4133 +/- ##
==========================================
- Coverage 27.26% 27.18% -0.08%
==========================================
Files 1141 1145 +4
Lines 25057 25100 +43
Branches 3625 3629 +4
==========================================
- Hits 6831 6824 -7
- Misses 17620 17670 +50
Partials 606 606
Continue to review full report at Codecov.
|
@mrproliu Does the configs need TTL and why? As you wrote in #4144 , monitoring tasks are stored in the inventory here, I suppose the tasks are created by users in the web UI right? So why they should be deleted after a so-called TTL? Does the users expect this? Is it designed for so? |
Monitoring should be set by UI or GraphQL. But it isn't inventory, that is why we create a new type of streaming process. I think the point of deleting is the thread dump will be saved as a kind of record, similar to the segment. So even we don't set up TTL, it will miss all related thread dump data. @mrproliu A reminder to you, as TTL setup based on time bucket, this field should be set based on task expected finish time, rather than config time. Because you need to avoid the task has been deleted before the task starts. Also, I notice, this task entity is not time series, why? Deleting is a big payload for the ES, I would recommend setup the time series for this too. Request rename
|
So, is |
I agree with all your suggestions. I will change that today. |
No, It will create base on |
2. add comments on none stream relate classes
@wu-sheng All issue has been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @kezhenxu94 @arugal Recheck?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
[FEATURE] Performance profile at method level in production environment #4104
New feature or improvement