Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE… #5031

Merged
merged 5 commits into from
Jul 17, 2020

Conversation

dagmom
Copy link
Contributor

@dagmom dagmom commented Jul 5, 2020

…ncoder + TradeIdJsonProvider in logback.xml

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

issue 3713


New feature or improvement

  • How to fix?
    LogstashTcpSocketAppender enhance class put TID to ILoggingEvent, but ConsoleAppender don't use ILoggingEvent , so enhance TraceIdJsonProvider class and set traceId

@wu-sheng wu-sheng added agent Language agent related. enhancement Enhancement on performance or codes labels Jul 5, 2020
@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #5031 into master will decrease coverage by 0.19%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5031      +/-   ##
============================================
- Coverage     53.15%   52.96%   -0.20%     
+ Complexity     2993     2984       -9     
============================================
  Files           777     1419     +642     
  Lines         19514    30727   +11213     
  Branches       1924     3420    +1496     
============================================
+ Hits          10373    16274    +5901     
- Misses         8288    13648    +5360     
+ Partials        853      805      -48     
Impacted Files Coverage Δ Complexity Δ
...log/logback/v1/x/logstash/TraceIdJsonProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...k/v1/x/logstash/TraceIdJsonProviderActivation.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../v1/x/logstash/TraceIdJsonProviderInterceptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...erver/receiver/envoy/MetricServiceGRPCHandler.java 12.16% <0.00%> (-77.84%) 2.00% <0.00%> (ø%)
...er/receiver/envoy/AccessLogServiceGRPCHandler.java 20.75% <0.00%> (-37.15%) 2.00% <0.00%> (ø%)
...skywalking/oap/server/core/alarm/AlarmMessage.java 66.66% <0.00%> (-33.34%) 2.00% <0.00%> (ø%)
...r/cluster/plugin/standalone/StandaloneManager.java 77.77% <0.00%> (-22.23%) 3.00% <0.00%> (-1.00%)
...ient/elasticsearch/ElasticSearchInsertRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...ient/elasticsearch/ElasticSearchUpdateRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...ticsearch7/client/ElasticSearch7UpdateRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
... and 966 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9cbe2...5871fa8. Read the comment docs.

@zhaoyuguang zhaoyuguang self-requested a review July 5, 2020 05:04
@zhaoyuguang
Copy link
Member

The following two problems were found
1 org.apache.commons.lang3.StringUtils class not found
image

2 why use allArguments[0] getTracingId has no args
image

@zhaoyuguang
Copy link
Member

zhaoyuguang commented Jul 5, 2020

@dagmom
What kind of demo, The TraceIdJsonProviderInterceptor.java code logic will go here?
image

@dagmom
Copy link
Contributor Author

dagmom commented Jul 5, 2020

@dagmom
What kind of demo, The TraceIdJsonProviderInterceptor.java code logic will go here?
image

@zhaoyuguang Maybe async log enhance by AsyncAppenderBaseMethodInterceptor,let me verify that.

@dagmom
Copy link
Contributor Author

dagmom commented Jul 14, 2020

image

image

@zhaoyuguang I have confirmed it in the async log

@zhaoyuguang
Copy link
Member

Sorry for the delay, I'm will testing asynchrony as soon

@zhaoyuguang
Copy link
Member

LGTM @dagmom Please deal This branch is out-of-date with the base branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. enhancement Enhancement on performance or codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot get the TID using the ConsoleAppender +LogstashEncoder+TradeIdJsonProvider
3 participants