-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue 3713 - Cannot get the TID using the ConsoleAppender + LogstashE… #5031
Conversation
…ncoder + TradeIdJsonProvider in logback.xml
Codecov Report
@@ Coverage Diff @@
## master #5031 +/- ##
============================================
- Coverage 53.15% 52.96% -0.20%
+ Complexity 2993 2984 -9
============================================
Files 777 1419 +642
Lines 19514 30727 +11213
Branches 1924 3420 +1496
============================================
+ Hits 10373 16274 +5901
- Misses 8288 13648 +5360
+ Partials 853 805 -48 Continue to review full report at Codecov.
|
@dagmom |
@zhaoyuguang Maybe async log enhance by |
@zhaoyuguang I have confirmed it in the async log |
Sorry for the delay, I'm will testing asynchrony as soon |
LGTM @dagmom Please deal |
…ncoder + TradeIdJsonProvider in logback.xml
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
issue 3713
New feature or improvement
LogstashTcpSocketAppender
enhance class putTID
toILoggingEvent
, butConsoleAppender
don't useILoggingEvent
, so enhanceTraceIdJsonProvider
class and set traceId