Fix no telemetry metrics when the oap role is receiver. #5038

Ax1an · 2020-07-06T07:47:24Z

Please answer these questions before submitting pull request

Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues

Bug fix

Bug description.

No telemetry metrics when the oap role is receiver. Only jvm metrics is exposed.

# HELP jvm_info JVM version info
# TYPE jvm_info gauge
jvm_info{version="1.8.0_231-b11",vendor="Oracle Corporation",runtime="Java(TM) SE Runtime Environment",} 1.0
# HELP jvm_threads_current Current thread count of a JVM
# TYPE jvm_threads_current gauge
jvm_threads_current 118.0
# HELP jvm_threads_daemon Daemon thread count of a JVM
# TYPE jvm_threads_daemon gauge
jvm_threads_daemon 83.0
# HELP jvm_threads_peak Peak thread count of a JVM
# TYPE jvm_threads_peak gauge
jvm_threads_peak 121.0
# HELP jvm_threads_started_total Started thread count of a JVM
# TYPE jvm_threads_started_total counter
jvm_threads_started_total 124.0
# HELP jvm_threads_deadlocked Cycles of JVM-threads that are in deadlock waiting to acquire object monitors or ownable synchronizers
# TYPE jvm_threads_deadlocked gauge
jvm_threads_deadlocked 0.0
# HELP jvm_threads_deadlocked_monitor Cycles of JVM-threads that are in deadlock waiting to acquire object monitors
# TYPE jvm_threads_deadlocked_monitor gauge
jvm_threads_deadlocked_monitor 0.0
# HELP jvm_threads_state Current count of threads by state
# TYPE jvm_threads_state gauge
jvm_threads_state{state="WAITING",} 9.0
jvm_threads_state{state="NEW",} 0.0
jvm_threads_state{state="TERMINATED",} 0.0
jvm_threads_state{state="TIMED_WAITING",} 68.0
jvm_threads_state{state="RUNNABLE",} 41.0
jvm_threads_state{state="BLOCKED",} 0.0
# HELP process_cpu_seconds_total Total user and system CPU time spent in seconds.
# TYPE process_cpu_seconds_total counter
process_cpu_seconds_total 35.110968
# HELP process_start_time_seconds Start time of the process since unix epoch in seconds.
# TYPE process_start_time_seconds gauge
process_start_time_seconds 1.594015769031E9
# HELP process_open_fds Number of open file descriptors.
# TYPE process_open_fds gauge
process_open_fds 322.0
# HELP process_max_fds Maximum number of open file descriptors.
# TYPE process_max_fds gauge
process_max_fds 10240.0
# HELP jvm_memory_bytes_used Used bytes of a given JVM memory area.
# TYPE jvm_memory_bytes_used gauge
jvm_memory_bytes_used{area="heap",} 2.72458E8
jvm_memory_bytes_used{area="nonheap",} 9.034496E7
# HELP jvm_memory_bytes_committed Committed (bytes) of a given JVM memory area.
# TYPE jvm_memory_bytes_committed gauge
jvm_memory_bytes_committed{area="heap",} 8.98629632E8
jvm_memory_bytes_committed{area="nonheap",} 9.33888E7
# HELP jvm_memory_bytes_max Max (bytes) of a given JVM memory area.
# TYPE jvm_memory_bytes_max gauge
jvm_memory_bytes_max{area="heap",} 3.817865216E9
jvm_memory_bytes_max{area="nonheap",} -1.0
# HELP jvm_memory_bytes_init Initial bytes of a given JVM memory area.
# TYPE jvm_memory_bytes_init gauge
jvm_memory_bytes_init{area="heap",} 2.68435456E8
jvm_memory_bytes_init{area="nonheap",} 2555904.0
# HELP jvm_memory_pool_bytes_used Used bytes of a given JVM memory pool.
# TYPE jvm_memory_pool_bytes_used gauge
jvm_memory_pool_bytes_used{pool="Code Cache",} 1.794784E7
jvm_memory_pool_bytes_used{pool="Metaspace",} 6.4289096E7
jvm_memory_pool_bytes_used{pool="Compressed Class Space",} 8108024.0
jvm_memory_pool_bytes_used{pool="PS Eden Space",} 2.41183192E8
jvm_memory_pool_bytes_used{pool="PS Survivor Space",} 0.0
jvm_memory_pool_bytes_used{pool="PS Old Gen",} 3.1274808E7
# HELP jvm_memory_pool_bytes_committed Committed bytes of a given JVM memory pool.
# TYPE jvm_memory_pool_bytes_committed gauge
jvm_memory_pool_bytes_committed{pool="Code Cache",} 1.867776E7
jvm_memory_pool_bytes_committed{pool="Metaspace",} 6.6060288E7
jvm_memory_pool_bytes_committed{pool="Compressed Class Space",} 8650752.0
jvm_memory_pool_bytes_committed{pool="PS Eden Space",} 6.67418624E8
jvm_memory_pool_bytes_committed{pool="PS Survivor Space",} 1.6252928E7
jvm_memory_pool_bytes_committed{pool="PS Old Gen",} 2.1495808E8
# HELP jvm_memory_pool_bytes_max Max bytes of a given JVM memory pool.
# TYPE jvm_memory_pool_bytes_max gauge
jvm_memory_pool_bytes_max{pool="Code Cache",} 2.5165824E8
jvm_memory_pool_bytes_max{pool="Metaspace",} -1.0
jvm_memory_pool_bytes_max{pool="Compressed Class Space",} 1.073741824E9
jvm_memory_pool_bytes_max{pool="PS Eden Space",} 1.379926016E9
jvm_memory_pool_bytes_max{pool="PS Survivor Space",} 1.6252928E7
jvm_memory_pool_bytes_max{pool="PS Old Gen",} 2.863661056E9
# HELP jvm_memory_pool_bytes_init Initial bytes of a given JVM memory pool.
# TYPE jvm_memory_pool_bytes_init gauge
jvm_memory_pool_bytes_init{pool="Code Cache",} 2555904.0
jvm_memory_pool_bytes_init{pool="Metaspace",} 0.0
jvm_memory_pool_bytes_init{pool="Compressed Class Space",} 0.0
jvm_memory_pool_bytes_init{pool="PS Eden Space",} 6.7108864E7
jvm_memory_pool_bytes_init{pool="PS Survivor Space",} 1.1010048E7
jvm_memory_pool_bytes_init{pool="PS Old Gen",} 1.79306496E8
# HELP jvm_buffer_pool_used_bytes Used bytes of a given JVM buffer pool.
# TYPE jvm_buffer_pool_used_bytes gauge
jvm_buffer_pool_used_bytes{pool="direct",} 76424.0
jvm_buffer_pool_used_bytes{pool="mapped",} 0.0
# HELP jvm_buffer_pool_capacity_bytes Bytes capacity of a given JVM buffer pool.
# TYPE jvm_buffer_pool_capacity_bytes gauge
jvm_buffer_pool_capacity_bytes{pool="direct",} 76423.0
jvm_buffer_pool_capacity_bytes{pool="mapped",} 0.0
# HELP jvm_buffer_pool_used_buffers Used buffers of a given JVM buffer pool.
# TYPE jvm_buffer_pool_used_buffers gauge
jvm_buffer_pool_used_buffers{pool="direct",} 12.0
jvm_buffer_pool_used_buffers{pool="mapped",} 0.0
# HELP jvm_classes_loaded The number of classes that are currently loaded in the JVM
# TYPE jvm_classes_loaded gauge
jvm_classes_loaded 11775.0
# HELP jvm_classes_loaded_total The total number of classes that have been loaded since the JVM has started execution
# TYPE jvm_classes_loaded_total counter
jvm_classes_loaded_total 11779.0
# HELP jvm_classes_unloaded_total The total number of classes that have been unloaded since the JVM has started execution
# TYPE jvm_classes_unloaded_total counter
jvm_classes_unloaded_total 4.0
# HELP jvm_memory_pool_allocated_bytes_total Total bytes allocated in a given JVM memory pool. Only updated after GC, not continuously.
# TYPE jvm_memory_pool_allocated_bytes_total counter
jvm_memory_pool_allocated_bytes_total{pool="Code Cache",} 1.8067072E7
jvm_memory_pool_allocated_bytes_total{pool="PS Eden Space",} 1.571292488E9
jvm_memory_pool_allocated_bytes_total{pool="PS Old Gen",} 3.132976E7
jvm_memory_pool_allocated_bytes_total{pool="PS Survivor Space",} 3.655128E7
jvm_memory_pool_allocated_bytes_total{pool="Compressed Class Space",} 7514864.0
jvm_memory_pool_allocated_bytes_total{pool="Metaspace",} 5.9126248E7
# HELP jvm_gc_collection_seconds Time spent in a given JVM garbage collector in seconds.
# TYPE jvm_gc_collection_seconds summary
jvm_gc_collection_seconds_count{gc="PS Scavenge",} 16.0
jvm_gc_collection_seconds_sum{gc="PS Scavenge",} 0.158
jvm_gc_collection_seconds_count{gc="PS MarkSweep",} 3.0
jvm_gc_collection_seconds_sum{gc="PS MarkSweep",} 0.148

How to fix?

Setting id for telemetry related context. After setting, you can see the telemetry metrics.
For example, metrics_aggregation, persistence_timer_bulk_execute_latency, and so on.

# HELP jvm_buffer_pool_used_bytes Used bytes of a given JVM buffer pool.
# TYPE jvm_buffer_pool_used_bytes gauge
jvm_buffer_pool_used_bytes{pool="direct",} 72389.0
jvm_buffer_pool_used_bytes{pool="mapped",} 0.0
# HELP jvm_buffer_pool_capacity_bytes Bytes capacity of a given JVM buffer pool.
# TYPE jvm_buffer_pool_capacity_bytes gauge
jvm_buffer_pool_capacity_bytes{pool="direct",} 72388.0
jvm_buffer_pool_capacity_bytes{pool="mapped",} 0.0
# HELP jvm_buffer_pool_used_buffers Used buffers of a given JVM buffer pool.
# TYPE jvm_buffer_pool_used_buffers gauge
jvm_buffer_pool_used_buffers{pool="direct",} 11.0
jvm_buffer_pool_used_buffers{pool="mapped",} 0.0
# HELP jvm_classes_loaded The number of classes that are currently loaded in the JVM
# TYPE jvm_classes_loaded gauge
jvm_classes_loaded 11800.0
# HELP jvm_classes_loaded_total The total number of classes that have been loaded since the JVM has started execution
# TYPE jvm_classes_loaded_total counter
jvm_classes_loaded_total 11804.0
# HELP jvm_classes_unloaded_total The total number of classes that have been unloaded since the JVM has started execution
# TYPE jvm_classes_unloaded_total counter
jvm_classes_unloaded_total 4.0
# HELP persistence_timer_bulk_execute_latency Latency of the execute stage in persistence timer
# TYPE persistence_timer_bulk_execute_latency histogram
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.005",} 8.0
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.01",} 8.0
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.025",} 8.0
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.05",} 8.0
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.075",} 8.0
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.1",} 8.0
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.25",} 8.0
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.5",} 8.0
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.75",} 8.0
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="1.0",} 8.0
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="2.5",} 8.0
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="5.0",} 8.0
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="7.5",} 8.0
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="10.0",} 8.0
persistence_timer_bulk_execute_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="+Inf",} 8.0
persistence_timer_bulk_execute_latency_count{sw_backend_instance="192.168.46.203_11800",} 8.0
persistence_timer_bulk_execute_latency_sum{sw_backend_instance="192.168.46.203_11800",} 2.2112E-5
# HELP metrics_aggregation The number of rows in aggregation
# TYPE metrics_aggregation counter
metrics_aggregation{sw_backend_instance="192.168.46.203_11800",metricName="meter_instance_jvm_young_gc_count",level="1",dimensionality="minute",} 2.0
metrics_aggregation{sw_backend_instance="192.168.46.203_11800",metricName="meter_instance_jvm_old_gc_time",level="1",dimensionality="minute",} 2.0
metrics_aggregation{sw_backend_instance="192.168.46.203_11800",metricName="service_traffic",level="1",dimensionality="minute",} 15.0
metrics_aggregation{sw_backend_instance="192.168.46.203_11800",metricName="meter_instance_metrics_first_aggregation",level="1",dimensionality="minute",} 1.0
metrics_aggregation{sw_backend_instance="192.168.46.203_11800",metricName="instance_traffic",level="1",dimensionality="minute",} 15.0
metrics_aggregation{sw_backend_instance="192.168.46.203_11800",metricName="meter_instance_jvm_young_gc_time",level="1",dimensionality="minute",} 2.0
metrics_aggregation{sw_backend_instance="192.168.46.203_11800",metricName="meter_instance_persistence_timer_execute_latency_percentile",level="1",dimensionality="minute",} 1.0
metrics_aggregation{sw_backend_instance="192.168.46.203_11800",metricName="meter_instance_persistence_timer_prepare_latency_percentile",level="1",dimensionality="minute",} 1.0
metrics_aggregation{sw_backend_instance="192.168.46.203_11800",metricName="meter_instance_persistence_timer_execute_count",level="1",dimensionality="minute",} 1.0
metrics_aggregation{sw_backend_instance="192.168.46.203_11800",metricName="meter_instance_jvm_memory_bytes_used",level="1",dimensionality="minute",} 2.0
metrics_aggregation{sw_backend_instance="192.168.46.203_11800",metricName="meter_instance_cpu_percentage",level="1",dimensionality="minute",} 2.0
metrics_aggregation{sw_backend_instance="192.168.46.203_11800",metricName="meter_instance_persistence_timer_prepare_count",level="1",dimensionality="minute",} 1.0
# HELP jvm_info JVM version info
# TYPE jvm_info gauge
jvm_info{version="1.8.0_231-b11",vendor="Oracle Corporation",runtime="Java(TM) SE Runtime Environment",} 1.0
# HELP jvm_threads_current Current thread count of a JVM
# TYPE jvm_threads_current gauge
jvm_threads_current 117.0
# HELP jvm_threads_daemon Daemon thread count of a JVM
# TYPE jvm_threads_daemon gauge
jvm_threads_daemon 82.0
# HELP jvm_threads_peak Peak thread count of a JVM
# TYPE jvm_threads_peak gauge
jvm_threads_peak 117.0
# HELP jvm_threads_started_total Started thread count of a JVM
# TYPE jvm_threads_started_total counter
jvm_threads_started_total 119.0
# HELP jvm_threads_deadlocked Cycles of JVM-threads that are in deadlock waiting to acquire object monitors or ownable synchronizers
# TYPE jvm_threads_deadlocked gauge
jvm_threads_deadlocked 0.0
# HELP jvm_threads_deadlocked_monitor Cycles of JVM-threads that are in deadlock waiting to acquire object monitors
# TYPE jvm_threads_deadlocked_monitor gauge
jvm_threads_deadlocked_monitor 0.0
# HELP jvm_threads_state Current count of threads by state
# TYPE jvm_threads_state gauge
jvm_threads_state{state="WAITING",} 9.0
jvm_threads_state{state="NEW",} 0.0
jvm_threads_state{state="TERMINATED",} 0.0
jvm_threads_state{state="TIMED_WAITING",} 71.0
jvm_threads_state{state="RUNNABLE",} 37.0
jvm_threads_state{state="BLOCKED",} 0.0
# HELP process_cpu_seconds_total Total user and system CPU time spent in seconds.
# TYPE process_cpu_seconds_total counter
process_cpu_seconds_total 28.321699
# HELP process_start_time_seconds Start time of the process since unix epoch in seconds.
# TYPE process_start_time_seconds gauge
process_start_time_seconds 1.594016020813E9
# HELP process_open_fds Number of open file descriptors.
# TYPE process_open_fds gauge
process_open_fds 321.0
# HELP process_max_fds Maximum number of open file descriptors.
# TYPE process_max_fds gauge
process_max_fds 10240.0
# HELP jvm_memory_bytes_used Used bytes of a given JVM memory area.
# TYPE jvm_memory_bytes_used gauge
jvm_memory_bytes_used{area="heap",} 2.90464424E8
jvm_memory_bytes_used{area="nonheap",} 8.9843344E7
# HELP jvm_memory_bytes_committed Committed (bytes) of a given JVM memory area.
# TYPE jvm_memory_bytes_committed gauge
jvm_memory_bytes_committed{area="heap",} 9.00202496E8
jvm_memory_bytes_committed{area="nonheap",} 9.3585408E7
# HELP jvm_memory_bytes_max Max (bytes) of a given JVM memory area.
# TYPE jvm_memory_bytes_max gauge
jvm_memory_bytes_max{area="heap",} 3.817865216E9
jvm_memory_bytes_max{area="nonheap",} -1.0
# HELP jvm_memory_bytes_init Initial bytes of a given JVM memory area.
# TYPE jvm_memory_bytes_init gauge
jvm_memory_bytes_init{area="heap",} 2.68435456E8
jvm_memory_bytes_init{area="nonheap",} 2555904.0
# HELP jvm_memory_pool_bytes_used Used bytes of a given JVM memory pool.
# TYPE jvm_memory_pool_bytes_used gauge
jvm_memory_pool_bytes_used{pool="Code Cache",} 1.7494464E7
jvm_memory_pool_bytes_used{pool="Metaspace",} 6.4223896E7
jvm_memory_pool_bytes_used{pool="Compressed Class Space",} 8124984.0
jvm_memory_pool_bytes_used{pool="PS Eden Space",} 2.57842816E8
jvm_memory_pool_bytes_used{pool="PS Survivor Space",} 0.0
jvm_memory_pool_bytes_used{pool="PS Old Gen",} 3.2621608E7
# HELP jvm_memory_pool_bytes_committed Committed bytes of a given JVM memory pool.
# TYPE jvm_memory_pool_bytes_committed gauge
jvm_memory_pool_bytes_committed{pool="Code Cache",} 1.8874368E7
jvm_memory_pool_bytes_committed{pool="Metaspace",} 6.6060288E7
jvm_memory_pool_bytes_committed{pool="Compressed Class Space",} 8650752.0
jvm_memory_pool_bytes_committed{pool="PS Eden Space",} 6.28621312E8
jvm_memory_pool_bytes_committed{pool="PS Survivor Space",} 3.4603008E7
jvm_memory_pool_bytes_committed{pool="PS Old Gen",} 2.36978176E8
# HELP jvm_memory_pool_bytes_max Max bytes of a given JVM memory pool.
# TYPE jvm_memory_pool_bytes_max gauge
jvm_memory_pool_bytes_max{pool="Code Cache",} 2.5165824E8
jvm_memory_pool_bytes_max{pool="Metaspace",} -1.0
jvm_memory_pool_bytes_max{pool="Compressed Class Space",} 1.073741824E9
jvm_memory_pool_bytes_max{pool="PS Eden Space",} 1.352138752E9
jvm_memory_pool_bytes_max{pool="PS Survivor Space",} 3.4603008E7
jvm_memory_pool_bytes_max{pool="PS Old Gen",} 2.863661056E9
# HELP jvm_memory_pool_bytes_init Initial bytes of a given JVM memory pool.
# TYPE jvm_memory_pool_bytes_init gauge
jvm_memory_pool_bytes_init{pool="Code Cache",} 2555904.0
jvm_memory_pool_bytes_init{pool="Metaspace",} 0.0
jvm_memory_pool_bytes_init{pool="Compressed Class Space",} 0.0
jvm_memory_pool_bytes_init{pool="PS Eden Space",} 6.7108864E7
jvm_memory_pool_bytes_init{pool="PS Survivor Space",} 1.1010048E7
jvm_memory_pool_bytes_init{pool="PS Old Gen",} 1.79306496E8
# HELP uptime oap server start up time
# TYPE uptime gauge
uptime{sw_backend_instance="192.168.46.203_11800",} 1.594016039539E9
# HELP remote_out_count The number(client side) of inside remote inside aggregate rpc.
# TYPE remote_out_count counter
remote_out_count{sw_backend_instance="192.168.46.203_11800",dest="10.81.84.89_11800",self="N",} 23.0
# HELP cluster_size Cluster size of current oap node
# TYPE cluster_size gauge
cluster_size{sw_backend_instance="192.168.46.203_11800",} 1.0
# HELP jvm_memory_pool_allocated_bytes_total Total bytes allocated in a given JVM memory pool. Only updated after GC, not continuously.
# TYPE jvm_memory_pool_allocated_bytes_total counter
jvm_memory_pool_allocated_bytes_total{pool="Code Cache",} 1.8737152E7
jvm_memory_pool_allocated_bytes_total{pool="PS Eden Space",} 1.554529624E9
jvm_memory_pool_allocated_bytes_total{pool="PS Old Gen",} 8.0695104E7
jvm_memory_pool_allocated_bytes_total{pool="PS Survivor Space",} 3.5909448E7
jvm_memory_pool_allocated_bytes_total{pool="Compressed Class Space",} 7496080.0
jvm_memory_pool_allocated_bytes_total{pool="Metaspace",} 5.9130136E7
# HELP jvm_gc_collection_seconds Time spent in a given JVM garbage collector in seconds.
# TYPE jvm_gc_collection_seconds summary
jvm_gc_collection_seconds_count{gc="PS Scavenge",} 16.0
jvm_gc_collection_seconds_sum{gc="PS Scavenge",} 0.176
jvm_gc_collection_seconds_count{gc="PS MarkSweep",} 3.0
jvm_gc_collection_seconds_sum{gc="PS MarkSweep",} 0.15
# HELP persistence_timer_bulk_prepare_latency Latency of the prepare stage in persistence timer
# TYPE persistence_timer_bulk_prepare_latency histogram
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.005",} 8.0
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.01",} 8.0
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.025",} 8.0
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.05",} 8.0
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.075",} 8.0
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.1",} 8.0
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.25",} 8.0
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.5",} 8.0
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="0.75",} 8.0
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="1.0",} 8.0
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="2.5",} 8.0
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="5.0",} 8.0
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="7.5",} 8.0
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="10.0",} 8.0
persistence_timer_bulk_prepare_latency_bucket{sw_backend_instance="192.168.46.203_11800",le="+Inf",} 8.0
persistence_timer_bulk_prepare_latency_count{sw_backend_instance="192.168.46.203_11800",} 8.0
persistence_timer_bulk_prepare_latency_sum{sw_backend_instance="192.168.46.203_11800",} 0.006293092

New feature or improvement

Describe the details and related test reports.

wu-sheng

LGTM. FYI @hanahmily

codecov · 2020-07-06T07:54:13Z

Codecov Report

Merging #5038 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #5038      +/-   ##
============================================
- Coverage     53.14%   53.12%   -0.03%     
- Complexity     2963     2972       +9     
============================================
  Files           772     1409     +637     
  Lines         19377    30591   +11214     
  Branches       1915     3405    +1490     
============================================
+ Hits          10297    16250    +5953     
- Misses         8223    13537    +5314     
+ Partials        857      804      -53

Impacted Files	Coverage Δ	Complexity Δ
...erver/cluster/plugin/consul/ConsulCoordinator.java	`97.05% <ø> (+97.05%)`	`0.00 <0.00> (ø)`
...ap/server/cluster/plugin/etcd/EtcdCoordinator.java	`71.92% <ø> (+71.92%)`	`0.00 <0.00> (ø)`
...uster/plugin/kubernetes/KubernetesCoordinator.java	`85.18% <ø> (+85.18%)`	`0.00 <0.00> (ø)`
...r/cluster/plugin/standalone/StandaloneManager.java	`77.77% <ø> (-2.23%)`	`3.00 <0.00> (ø)`
...cluster/plugin/zookeeper/ZookeeperCoordinator.java	`64.86% <ø> (+64.86%)`	`0.00 <0.00> (ø)`
...skywalking/oap/server/core/CoreModuleProvider.java	`79.86% <100.00%> (+0.14%)`	`9.00 <0.00> (ø)`
...erver/receiver/envoy/MetricServiceGRPCHandler.java	`12.16% <0.00%> (-77.84%)`	`2.00% <0.00%> (ø%)`
...er/receiver/envoy/AccessLogServiceGRPCHandler.java	`20.75% <0.00%> (-37.15%)`	`2.00% <0.00%> (ø%)`
...skywalking/oap/server/core/alarm/AlarmMessage.java	`66.66% <0.00%> (-33.34%)`	`2.00% <0.00%> (ø%)`
...ient/elasticsearch/ElasticSearchInsertRequest.java	`80.00% <0.00%> (-20.00%)`	`2.00% <0.00%> (ø%)`
... and 966 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3ae7b4...e6399f4. Read the comment docs.

...rver/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java

Fix no telemetry metrics when the oap role is receiver.

a0998ff

wu-sheng previously approved these changes Jul 6, 2020

View reviewed changes

add import class

4a36811

Ax1an dismissed wu-sheng’s stale review via 4a36811 July 6, 2020 07:57

wu-sheng reviewed Jul 6, 2020

View reviewed changes

...rver/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java Show resolved Hide resolved

wu-sheng added backend OAP backend related. bug Something isn't working and you are sure it's a bug! labels Jul 6, 2020

wu-sheng added this to the 8.1.0 milestone Jul 6, 2020

Remove all #setId in the coordinator implementations.

e6399f4

wu-sheng approved these changes Jul 6, 2020

View reviewed changes

wu-sheng merged commit 3df2e8d into apache:master Jul 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix no telemetry metrics when the oap role is receiver. #5038

Fix no telemetry metrics when the oap role is receiver. #5038

Ax1an commented Jul 6, 2020 •

edited

wu-sheng left a comment

codecov bot commented Jul 6, 2020 •

edited

Fix no telemetry metrics when the oap role is receiver. #5038

Fix no telemetry metrics when the oap role is receiver. #5038

Conversation

Ax1an commented Jul 6, 2020 • edited

Bug fix

New feature or improvement

wu-sheng left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 6, 2020 • edited

Codecov Report

Ax1an commented Jul 6, 2020 •

edited

codecov bot commented Jul 6, 2020 •

edited