Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add istioctl ALS command for document #5066

Merged
merged 4 commits into from Jul 9, 2020

Conversation

lyzhang1999
Copy link
Contributor

Related issues
#5060

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #5066 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5066      +/-   ##
============================================
+ Coverage     53.14%   53.16%   +0.01%     
- Complexity     2974     2975       +1     
============================================
  Files          1410     1410              
  Lines         30607    30607              
  Branches       3404     3404              
============================================
+ Hits          16267    16271       +4     
+ Misses        13538    13533       -5     
- Partials        802      803       +1     
Impacted Files Coverage Δ Complexity Δ
...er/storage/plugin/influxdb/query/MetricsQuery.java 50.83% <0.00%> (-0.84%) 10.00% <0.00%> (-1.00%)
...meter/function/AvgHistogramPercentileFunction.java 61.76% <0.00%> (-0.74%) 20.00% <0.00%> (-1.00%)
...r/storage/plugin/influxdb/query/MetadataQuery.java 60.00% <0.00%> (+0.76%) 12.00% <0.00%> (+1.00%)
...rary/client/elasticsearch/ElasticSearchClient.java 60.00% <0.00%> (+1.62%) 24.00% <0.00%> (ø%)
...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java 100.00% <0.00%> (+50.00%) 3.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f7ae0...3075910. Read the comment docs.

@hanahmily
Copy link
Contributor

@lyzhang1999 Thanks for your contribution, most look good except for some nits.

@wu-sheng wu-sheng added this to the 8.1.0 milestone Jul 9, 2020
@wu-sheng wu-sheng linked an issue Jul 9, 2020 that may be closed by this pull request
4 tasks
@wu-sheng wu-sheng added the documentation Provide documents related issue or pull request only. label Jul 9, 2020
@hanahmily hanahmily merged commit 20062c6 into apache:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provide documents related issue or pull request only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observe service mesh through ALS not working
3 participants