Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch quartz scheduler #5095

Closed
wants to merge 15 commits into from
Closed

Branch quartz scheduler #5095

wants to merge 15 commits into from

Conversation

tian-junwei
Copy link

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

Bug fix

  • Bug description.

  • How to fix?

New feature or improvement

  • Describe the details and related test reports.

归田 and others added 11 commits May 16, 2019 11:22
Merge pull request #1 from apache/master
4fab73a 
merge
Merge pull request #2 from apache/master
5f6153d 
merge
Merge pull request #3 from apache/master
899d27e 
merge
Merge pull request #4 from apache/master
f446878 
merge master
support for quartz-scheduler
a2206c2
Merge branch 'master' of https://github.com/apache/skywalking into ap…
e3a46f7 
…ache-master
Merge branch 'apache-master'
a608dbf
Merge branch 'master' into branch-quarzt-scheduler
3697a1b 
# Conflicts:
#	apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
#	apm-sniffer/apm-sdk-plugin/pom.xml
Merge pull request #6 from apache/master
4e24f1e 
Feat: add service filter in the template (apache#5081)
Merge pull request #8 from apache/master
8259d50 
merge
Merge branch 'master' of https://github.com/apache/skywalking into ap…
37da235 
…ache-master1

# Conflicts:
#	skywalking-ui
@wu-sheng
Copy link
Member

Why create a new one?

@codecov
Copy link

codecov bot commented Jul 14, 2020 •
edited

Codecov Report

Merging #5095 into master will increase coverage by 0.77%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5095      +/-   ##
============================================
+ Coverage     52.25%   53.03%   +0.77%     
- Complexity     2963     2990      +27     
============================================
  Files           778      778              
  Lines         19523    19519       -4     
  Branches       1924     1924              
============================================
+ Hits          10201    10351     +150     
+ Misses         8472     8306     -166     
- Partials        850      862      +12
Impacted Files Coverage Δ Complexity Δ
.../apm/network/trace/component/ComponentsDefine.java 98.64% <100.00%> (+0.01%) 1.00 <0.00> (ø)
...ing/oap/server/library/server/grpc/GRPCServer.java 49.15% <0.00%> (-11.87%) 6.00% <0.00%> (-1.00%)
...lysis/manual/networkalias/NetworkAddressAlias.java 58.53% <0.00%> (-4.88%) 5.00% <0.00%> (-1.00%)
...server/core/remote/client/RemoteClientManager.java 68.42% <0.00%> (-4.22%) 18.00% <0.00%> (-1.00%)
...skywalking/oap/server/core/CoreModuleProvider.java 75.69% <0.00%> (-4.17%) 9.00% <0.00%> (ø%)
...core/analysis/manual/instance/InstanceTraffic.java 56.00% <0.00%> (-4.00%) 7.00% <0.00%> (ø%)
...er/storage/plugin/influxdb/query/MetricsQuery.java 50.83% <0.00%> (-0.84%) 10.00% <0.00%> (-1.00%)
...ing/apm/agent/core/logging/core/PatternLogger.java 58.33% <0.00%> (ø) 20.00% <0.00%> (+2.00%)
...core/plugin/bytebuddy/AnnotationTypeNameMatch.java
...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce2469d...7f1e3de. Read the comment docs.

@tian-junwei
Copy link
Author

Why create a new one?

create a new branch want to do something and the old is deleted careless

wu-sheng
wu-sheng requested changes Jul 14, 2020
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. CI fails
  2. You should not update query-protocol
  3. The plugin test is still unprovided.

@wu-sheng wu-sheng added the TBD To be decided later, need more discussion or input. label Jul 14, 2020
@tian-junwei
Copy link
Author

  1. CI fails
  2. You should not update query-protocol
  3. The plugin test is still unprovided.

I dont konw the reason why the ' Compile all and Build docker image' is failed

@wu-sheng
Copy link
Member

Ignore istio-mixer-ci / build. That is another issue.

@wu-sheng wu-sheng added invalid The description doesn't fit the case. no update The owner doesn't provide further feedback. labels Aug 20, 2020
@wu-sheng wu-sheng added this to the 8.2.0 milestone Aug 20, 2020
@wu-sheng wu-sheng closed this Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng requested changes

Assignees
No one assigned
Labels
invalid The description doesn't fit the case. no update The owner doesn't provide further feedback. TBD To be decided later, need more discussion or input.
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tian-junwei @wu-sheng