Fix apdex threshold config bug when dynamic configuration is enabled. #5097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
Bug fix
Bug description.
Fix apdex threshold config bug when dynamic configuration is enabled.
This bug will result in a large number of warn logs, even if the service-apdex-threshold.yml file exist.
How to fix?
Optimize processing logic.
If there is a core.default.apdexThreshold in the dynamic configuration, use it.
If there is no core.default.apdexThreshold in the dynamic configuration, the service-apdex-threshold.yml file is read. And it is read only once when the configuration is switched. For example, delete core.default.apdexThreshold in the dynamic configuration.
Only print the warn log if the service-apdex-threshold.yml file does not exist.
New feature or improvement