Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support collecting feign params #5235

Merged
merged 8 commits into from Aug 6, 2020

Conversation

zshit
Copy link
Contributor

@zshit zshit commented Aug 5, 2020

Please answer these questions before submitting pull request

@kezhenxu94 kezhenxu94 linked an issue Aug 5, 2020 that may be closed by this pull request
4 tasks
@kezhenxu94 kezhenxu94 added this to the 8.2.0 milestone Aug 5, 2020
@kezhenxu94 kezhenxu94 added agent Language agent related. enhancement Enhancement on performance or codes plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. labels Aug 5, 2020
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #5235 into master will decrease coverage by 0.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5235      +/-   ##
============================================
- Coverage     53.11%   52.37%   -0.75%     
+ Complexity     3165     3145      -20     
============================================
  Files           821      820       -1     
  Lines         20524    20521       -3     
  Branches       1974     1974              
============================================
- Hits          10902    10748     -154     
- Misses         8739     8900     +161     
+ Partials        883      873      -10     
Impacted Files Coverage Δ Complexity Δ
...he/skywalking/apm/agent/core/context/tag/Tags.java 87.50% <100.00%> (+0.83%) 1.00 <0.00> (ø)
...in/influxdb/query/UITemplateManagementDAOImpl.java 1.75% <0.00%> (-85.97%) 1.00% <0.00%> (-6.00%)
...r/storage/plugin/influxdb/query/TopologyQuery.java 3.50% <0.00%> (-59.65%) 2.00% <0.00%> (-12.00%)
...er/storage/plugin/influxdb/query/MetricsQuery.java 23.33% <0.00%> (-28.34%) 6.00% <0.00%> (-5.00%)
.../server/storage/plugin/jdbc/h2/dao/H2BatchDAO.java 64.10% <0.00%> (-10.26%) 5.00% <0.00%> (ø%)
.../analyzer/provider/meter/process/MeterBuilder.java 40.62% <0.00%> (-4.69%) 7.00% <0.00%> (ø%)
...nalyzer/provider/meter/process/MeterProcessor.java 57.62% <0.00%> (-3.39%) 13.00% <0.00%> (ø%)
...ng/oap/server/core/alarm/provider/RunningRule.java 49.73% <0.00%> (-2.12%) 10.00% <0.00%> (ø%)
...p/server/storage/plugin/influxdb/InfluxClient.java 59.61% <0.00%> (-1.93%) 13.00% <0.00%> (-1.00%)
...r/storage/plugin/influxdb/query/MetadataQuery.java 57.69% <0.00%> (-1.54%) 10.00% <0.00%> (-1.00%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24eeb5d...230e780. Read the comment docs.

@zshit zshit force-pushed the support_collect_feign_params branch from e3ef7a5 to c3f1283 Compare August 5, 2020 15:43
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for CI to confirm.

@wu-sheng
Copy link
Member

wu-sheng commented Aug 6, 2020

Welcome to be 251st contributor.

@wu-sheng wu-sheng merged commit dd6f439 into apache:master Aug 6, 2020
x22x22 added a commit to x22x22/skywalking that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. enhancement Enhancement on performance or codes plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feign-plugin support collecting feign params
3 participants