add ignore *.log for hs_err_pid*.log/replay_pid*.log #5275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr conflicts with master. And where are these logs from? |
hs_err_pid*.log/replay_pid*.log generated when jvm crash on maven build.
hs_err_pid*.log/replay_pid*.log generated when jvm crash on maven build. |
|
That is unexpected, why we need to ignore those? We don't have tests for JVM crashing. The ignore file is not for all caees, it just ignore for tool config or test generated files. |
当构建时内存不足就会产生这些临时文件, we should ignore it just like target dir. |
|
You could have many files, such as dump file. It is not reasonable to add ignore for all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
Bug fix
Bug description.
How to fix?
New feature or improvement