New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mongo driver 4.x version. #5512
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5512 +/- ##
============================================
- Coverage 52.54% 52.39% -0.16%
- Complexity 3361 3364 +3
============================================
Files 1596 1603 +7
Lines 33947 34097 +150
Branches 3695 3720 +25
============================================
+ Hits 17839 17866 +27
- Misses 15256 15370 +114
- Partials 852 861 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, good to me. Several doc nits. And Test should be enhanced a little.
.../apache/skywalking/apm/plugin/mongodb/v4/define/MongoDBOperationExecutorInstrumentation.java
Outdated
Show resolved
Hide resolved
...rg/apache/skywalking/apm/plugin/mongodb/v4/interceptor/MongoDBClientDelegateInterceptor.java
Outdated
Show resolved
Hide resolved
...rg/apache/skywalking/apm/plugin/mongodb/v4/interceptor/MongoDBClientDelegateInterceptor.java
Outdated
Show resolved
Hide resolved
...apache/skywalking/apm/plugin/mongodb/v4/interceptor/MongoDBOperationExecutorInterceptor.java
Outdated
Show resolved
Hide resolved
...apache/skywalking/apm/plugin/mongodb/v4/interceptor/MongoDBOperationExecutorInterceptor.java
Outdated
Show resolved
Hide resolved
...org/apache/skywalking/apm/plugin/mongodb/v4/define/MongoDBClientDelegateInstrumentation.java
Outdated
Show resolved
Hide resolved
...org/apache/skywalking/apm/plugin/mongodb/v4/define/MongoDBClientDelegateInstrumentation.java
Outdated
Show resolved
Hide resolved
...gin/src/main/java/org/apache/skywalking/apm/plugin/mongodb/v4/support/MongoPluginConfig.java
Show resolved
Hide resolved
…g/apache/skywalking/apm/plugin/mongodb/v4/define/MongoDBOperationExecutorInstrumentation.java Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
…g/apache/skywalking/apm/plugin/mongodb/v4/interceptor/MongoDBClientDelegateInterceptor.java Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
…g/apache/skywalking/apm/plugin/mongodb/v4/interceptor/MongoDBOperationExecutorInterceptor.java Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
…g/apache/skywalking/apm/plugin/mongodb/v4/interceptor/MongoDBClientDelegateInterceptor.java Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
…g/apache/skywalking/apm/plugin/mongodb/v4/interceptor/MongoDBOperationExecutorInterceptor.java Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
…g/apache/skywalking/apm/plugin/mongodb/v4/define/MongoDBClientDelegateInstrumentation.java Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
…g/apache/skywalking/apm/plugin/mongodb/v4/define/MongoDBClientDelegateInstrumentation.java Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
Please answer these questions before submitting a pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
Bug fix
Bug description.
How to fix?
New feature or improvement