Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mongo driver 4.x version. #5512

Merged
merged 34 commits into from Sep 22, 2020
Merged

Support mongo driver 4.x version. #5512

merged 34 commits into from Sep 22, 2020

Conversation

harvies
Copy link
Contributor

@harvies harvies commented Sep 17, 2020

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues


Bug fix

  • Bug description.

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #5512 into master will decrease coverage by 0.15%.
The diff coverage is 26.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5512      +/-   ##
============================================
- Coverage     52.54%   52.39%   -0.16%     
- Complexity     3361     3364       +3     
============================================
  Files          1596     1603       +7     
  Lines         33947    34097     +150     
  Branches       3695     3720      +25     
============================================
+ Hits          17839    17866      +27     
- Misses        15256    15370     +114     
- Partials        852      861       +9     
Impacted Files Coverage Δ Complexity Δ
...ugin/mongodb/v4/support/MongoRemotePeerHelper.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...lugin/mongodb/v4/support/MongoOperationHelper.java 7.46% <7.46%> (ø) 0.00 <0.00> (?)
.../interceptor/MongoDBClientDelegateInterceptor.java 42.85% <42.85%> (ø) 0.00 <0.00> (?)
...terceptor/MongoDBOperationExecutorInterceptor.java 83.33% <83.33%> (ø) 0.00 <0.00> (?)
...apm/plugin/mongodb/v4/support/MongoSpanHelper.java 85.71% <85.71%> (ø) 0.00 <0.00> (?)
...m/plugin/mongodb/v4/support/MongoPluginConfig.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...alking/apm/agent/core/context/util/PeerFormat.java 25.00% <0.00%> (-8.34%) 0.00% <0.00%> (ø%)
...erver/library/server/grpc/CustomThreadFactory.java 69.23% <0.00%> (-7.70%) 2.00% <0.00%> (-1.00%)
...core/analysis/manual/instance/InstanceTraffic.java 54.00% <0.00%> (-6.00%) 6.00% <0.00%> (-1.00%)
...er/storage/plugin/influxdb/query/MetricsQuery.java 43.92% <0.00%> (-0.94%) 8.00% <0.00%> (-1.00%)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3edd3d...4793e28. Read the comment docs.

@wu-sheng wu-sheng added agent Language agent related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. labels Sep 17, 2020
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, good to me. Several doc nits. And Test should be enhanced a little.

harvies and others added 6 commits September 18, 2020 18:23
…g/apache/skywalking/apm/plugin/mongodb/v4/define/MongoDBOperationExecutorInstrumentation.java

Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
…g/apache/skywalking/apm/plugin/mongodb/v4/interceptor/MongoDBClientDelegateInterceptor.java

Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
…g/apache/skywalking/apm/plugin/mongodb/v4/interceptor/MongoDBOperationExecutorInterceptor.java

Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
…g/apache/skywalking/apm/plugin/mongodb/v4/interceptor/MongoDBClientDelegateInterceptor.java

Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
…g/apache/skywalking/apm/plugin/mongodb/v4/interceptor/MongoDBOperationExecutorInterceptor.java

Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
…g/apache/skywalking/apm/plugin/mongodb/v4/define/MongoDBClientDelegateInstrumentation.java

Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
@harvies
Copy link
Contributor Author

harvies commented Sep 22, 2020

Can you retry the failed CI check for me?
image

@wu-sheng wu-sheng merged commit 1ff25ac into apache:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to find witnessClasses efficiently when adapting multi-version plug-ins?
2 participants