Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shardingsphere scenario remove commons-dbcp #5788

Merged
merged 6 commits into from
Nov 7, 2020
Merged

shardingsphere scenario remove commons-dbcp #5788

merged 6 commits into from
Nov 7, 2020

Conversation

yu199195
Copy link
Member

@yu199195 yu199195 commented Nov 4, 2020 •
edited

  • Tests(including UT, IT, E2E) are added to verify the new feature.

@codecov
Copy link

codecov bot commented Nov 4, 2020 •
edited

Codecov Report

Merging #5788 (644edf6) into master (b69aff1) will decrease coverage by 21.47%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #5788       +/-   ##
=============================================
- Coverage     50.99%   29.52%   -21.48%     
=============================================
  Files          1646     1577       -69     
  Lines         35295    33438     -1857     
  Branches       3843     4119      +276     
=============================================
- Hits          18000     9871     -8129     
- Misses        16393    22677     +6284     
+ Partials        902      890       -12
Impacted Files Coverage Δ Complexity Δ
...he/skywalking/oal/rt/output/DispatcherContext.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...skywalking/oal/rt/output/AllDispatcherContext.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...ache/skywalking/oap/server/core/source/Source.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...che/skywalking/oap/server/core/source/Service.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...he/skywalking/oap/server/core/source/Endpoint.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...he/skywalking/oap/server/core/source/GCPhrase.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...e/skywalking/oap/server/core/CoreModuleConfig.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
.../skywalking/oap/server/core/alarm/AlarmModule.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...ywalking/oap/server/core/config/ConfigService.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...ywalking/oap/server/core/exporter/ExportEvent.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
... and 743 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b69aff1...644edf6. Read the comment docs.

@wu-sheng wu-sheng added the test Test requirements about performance, feature or before release. label Nov 4, 2020
@wu-sheng wu-sheng added this to the 8.3.0 milestone Nov 4, 2020
@wu-sheng
Copy link
Member

wu-sheng commented Nov 4, 2020

Relate to #5550, try to remove DBCP from the test demo.

wu-sheng
wu-sheng requested changes Nov 4, 2020
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests don't work. Please recheck.

@yu199195
Copy link
Member Author

yu199195 commented Nov 7, 2020 •
edited

alreay rechecked! @wu-sheng

@kezhenxu94 kezhenxu94 merged commit d625f29 into apache:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
test Test requirements about performance, feature or before release.
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yu199195 @wu-sheng @kezhenxu94 @JaredTan95 @dmsolr